Skip to content

[fix](point query) Support mow table with sequence column#25308

Merged
dataroaring merged 1 commit into
apache:masterfrom
mymeiyi:fix-point-query-2
Oct 11, 2023
Merged

[fix](point query) Support mow table with sequence column#25308
dataroaring merged 1 commit into
apache:masterfrom
mymeiyi:fix-point-query-2

Conversation

@mymeiyi
Copy link
Copy Markdown
Contributor

@mymeiyi mymeiyi commented Oct 11, 2023

Proposed changes

If a MOW table contains a sequence column, the point query result is not correct.
Because the primary key index encode the sequence value at the end of each primary key, the point query key does not contain sequence value.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@mymeiyi
Copy link
Copy Markdown
Contributor Author

mymeiyi commented Oct 11, 2023

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Copy Markdown
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 36.25% (8151/22486)
Line Coverage: 28.36% (65194/229841)
Region Coverage: 27.30% (33789/123779)
Branch Coverage: 23.99% (17216/71764)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8dfcc9c1c8e4beaa5942f126c55cae8469fec72e_8dfcc9c1c8e4beaa5942f126c55cae8469fec72e/report/index.html

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Oct 11, 2023
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.41 seconds
stream load tsv: 558 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162396654 Bytes

Copy link
Copy Markdown
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged merge_conflict reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants