Skip to content

[fix](insert) improve group_commit related tests#25319

Merged
dataroaring merged 3 commits intoapache:masterfrom
mymeiyi:debug-insert_group_commit_into_duplicate
Oct 12, 2023
Merged

[fix](insert) improve group_commit related tests#25319
dataroaring merged 3 commits intoapache:masterfrom
mymeiyi:debug-insert_group_commit_into_duplicate

Conversation

@mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Oct 11, 2023 •
edited
Loading

Proposed changes

  1. Check if the group_commit related tests is executed by group commit or not.
  2. Make the commit interval configurable: group_commit_interval_seconds

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Oct 11, 2023

run p0

@mymeiyi mymeiyi force-pushed the debug-insert_group_commit_into_duplicate branch from b746d2a to ddca9d4 Compare October 11, 2023 10:58
@mymeiyi
Copy link
Contributor Author

mymeiyi commented Oct 11, 2023

run p0

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Oct 11, 2023

run compile p0

dataroaring
dataroaring previously approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

PR approved by anyone and no changes requested.

@mymeiyi mymeiyi changed the title [fix](insert) fix insert_group_commit_into_duplicate [fix](insert) improve group_commit related tests Oct 12, 2023
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 12, 2023
@mymeiyi mymeiyi force-pushed the debug-insert_group_commit_into_duplicate branch from 5fbadb2 to 47fc350 Compare October 12, 2023 08:47
@mymeiyi
Copy link
Contributor Author

mymeiyi commented Oct 12, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

clang-tidy review says "All clean, LGTM! 👍"

@mymeiyi mymeiyi force-pushed the debug-insert_group_commit_into_duplicate branch from 47fc350 to eaf1316 Compare October 12, 2023 09:00
@mymeiyi
Copy link
Contributor Author

mymeiyi commented Oct 12, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 12, 2023

TeamCity be ut coverage result:
Function Coverage: 36.23% (8154/22508)
Line Coverage: 28.33% (65279/230406)
Region Coverage: 27.04% (33797/124997)
Branch Coverage: 23.87% (17247/72258)
Coverage Report: http://coverage.selectdb-in.cc/coverage/47fc350da165bd4f4d1157b4aeb332ed122cba40_47fc350da165bd4f4d1157b4aeb332ed122cba40/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 12, 2023

TeamCity be ut coverage result:
Function Coverage: 36.22% (8154/22510)
Line Coverage: 28.33% (65291/230504)
Region Coverage: 27.04% (33815/125040)
Branch Coverage: 23.86% (17251/72302)
Coverage Report: http://coverage.selectdb-in.cc/coverage/eaf13164f68d97d774c0fa134a9b9e01e1088288_eaf13164f68d97d774c0fa134a9b9e01e1088288/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 12, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.55 seconds
stream load tsv: 578 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162376518 Bytes

@doris-robot
Copy link

doris-robot commented Oct 12, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.97 seconds
stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17161988130 Bytes

dataroaring
dataroaring approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 12, 2023
@hust-hhb
Copy link
Contributor

hust-hhb commented Oct 12, 2023

LGTM

hust-hhb
hust-hhb approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@hust-hhb hust-hhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 1073ef2 into apache:master Oct 12, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@mymeiyi
[fix](insert) improve group_commit related tests (apache#25319)
3b52a72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

+1 more reviewer

@hust-hhb hust-hhb hust-hhb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mymeiyi @doris-robot @hust-hhb @dataroaring