Skip to content

[fix](build) aarch64 compilation fix ##25443

Merged
yiguolei merged 1 commit intoapache:masterfrom
Nitin-Kashyap:buildfix-aarch64
Oct 16, 2023
Merged

[fix](build) aarch64 compilation fix ##25443
yiguolei merged 1 commit intoapache:masterfrom
Nitin-Kashyap:buildfix-aarch64

Conversation

@Nitin-Kashyap
Copy link
Contributor

@Nitin-Kashyap Nitin-Kashyap commented Oct 14, 2023

Proposed changes

Compilation to include execinfo when building on aarch64

Issue Number: close #25442

synchronized the include and usage of backtrace/unwind lib usage, for ccompilation fix

image

Issue: apache#25442

Compilation to include execinfo when building on aarch64
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 14, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@xinyiZzz
Copy link
Contributor

Thanks for your fix, in the future, libunwind will need to be verified on other platforms besides x86.

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
Copy link
Contributor

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.65% (8230/22456)
Line Coverage: 28.79% (65961/229130)
Region Coverage: 27.50% (34214/124420)
Branch Coverage: 24.20% (17413/71952)
Coverage Report: http://coverage.selectdb-in.cc/coverage/18863927cf596a770fa207837b0eca555ea44fce_18863927cf596a770fa207837b0eca555ea44fce/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.17 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.5 seconds inserted 10000000 Rows, about 338K ops/s
storage size: 17162098745 Bytes

@adonis0147
Copy link
Contributor

run p0

@yiguolei yiguolei merged commit 97c0af1 into apache:master Oct 16, 2023
xiaokang pushed a commit that referenced this pull request Oct 16, 2023
Issue: #25442

Compilation to include execinfo when building on aarch64
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
Issue: apache#25442

Compilation to include execinfo when building on aarch64
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
Issue: apache#25442

Compilation to include execinfo when building on aarch64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] compilation break for aarch64 platform

7 participants