Skip to content

[Fix](executor)Fix exchange operator can not aware end of file #25562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wangbo merged 1 commit into from
Oct 20, 2023
Merged

[Fix](executor)Fix exchange operator can not aware end of file #25562

wangbo merged 1 commit into from
Oct 20, 2023

Conversation

@wangbo
Copy link
Contributor

@wangbo wangbo commented Oct 18, 2023

Proposed changes

image

In some cases, the same shuffle client may duplicate send shuffle rpc even server has EOF.
This may result in delayed release of resources.

@wangbo
Copy link
Contributor Author

wangbo commented Oct 18, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 18, 2023

TeamCity be ut coverage result:
Function Coverage: 37.00% (8281/22381)
Line Coverage: 29.08% (66415/228404)
Region Coverage: 27.73% (34457/124277)
Branch Coverage: 24.35% (17512/71914)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bb23d62ba6e27ab9b883982931021376dc760e65_bb23d62ba6e27ab9b883982931021376dc760e65/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 18, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.86 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162042731 Bytes

HappenLee
HappenLee approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

PR approved by anyone and no changes requested.

Gabriel39
Gabriel39 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangbo wangbo merged commit a6925cc into apache:master Oct 20, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@wangbo
Fix exchange operator can not aware end of file (apache#25562)
8eb5ba7
xiaokang pushed a commit that referenced this pull request Nov 1, 2023
@wangbo
Fix exchange operator can not aware end of file #25562 (#26241)
4bb0e9e
@xiaokang xiaokang mentioned this pull request Nov 1, 2023
Merged
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
@wangbo
Fix exchange operator can not aware end of file apache#25562 (apache#…
d0a5dbb 
…26241)
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@wangbo
Fix exchange operator can not aware end of file (apache#25562)
f2f06e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@Gabriel39 Gabriel39 Gabriel39 approved these changes

@yiguolei yiguolei Awaiting requested review from yiguolei

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged merge_conflict reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wangbo @doris-robot @HappenLee @Gabriel39 @xiaokang