Skip to content

[improvement](fragment) optimize to get query context logic#25621

Merged
yiguolei merged 5 commits intoapache:masterfrom
sollhui:fragment
Oct 25, 2023
Merged

[improvement](fragment) optimize to get query context logic#25621
yiguolei merged 5 commits intoapache:masterfrom
sollhui:fragment

Conversation

@sollhui
Copy link
Copy Markdown
Contributor

@sollhui sollhui commented Oct 19, 2023

Proposed changes

When get query ctx, it can be get and return directly when other request has already create the query fragments context.It do not need create it again and then use the created ctx after create new one.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@sollhui
Copy link
Copy Markdown
Contributor Author

sollhui commented Oct 19, 2023

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.02% (8282/22371)
Line Coverage: 29.06% (66387/228471)
Region Coverage: 27.73% (34487/124387)
Branch Coverage: 24.33% (17521/72014)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6e49d6e8ae90eb2043b25c11701b5376e99b92ff_6e49d6e8ae90eb2043b25c11701b5376e99b92ff/report/index.html

@doris-robot
Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.76 seconds
stream load tsv: 559 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162100405 Bytes

@sollhui
Copy link
Copy Markdown
Contributor Author

sollhui commented Oct 19, 2023

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.03% (8285/22372)
Line Coverage: 29.08% (66438/228475)
Region Coverage: 27.73% (34492/124370)
Branch Coverage: 24.34% (17520/71986)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9cc5029a488cebda93dc1068d91e8f1bd6ee05be_9cc5029a488cebda93dc1068d91e8f1bd6ee05be/report/index.html

@doris-robot
Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.85 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162099703 Bytes

@sollhui
Copy link
Copy Markdown
Contributor Author

sollhui commented Oct 23, 2023

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.02% (8296/22410)
Line Coverage: 29.16% (66604/228426)
Region Coverage: 27.75% (34606/124699)
Branch Coverage: 24.41% (17576/72012)
Coverage Report: http://coverage.selectdb-in.cc/coverage/bcb9ac04e39c4450a78f2485dc12aac804de56c5_bcb9ac04e39c4450a78f2485dc12aac804de56c5/report/index.html

@doris-robot
Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.69 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162249955 Bytes

@sollhui
Copy link
Copy Markdown
Contributor Author

sollhui commented Oct 24, 2023

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.03% (8295/22398)
Line Coverage: 29.21% (66636/228131)
Region Coverage: 27.79% (34607/124534)
Branch Coverage: 24.47% (17584/71874)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e40ae524f9ce6ea250ff9e2c45e40f3b0bd44229_e40ae524f9ce6ea250ff9e2c45e40f3b0bd44229/report/index.html

@doris-robot
Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.68 seconds
stream load tsv: 551 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162145500 Bytes

@sollhui
Copy link
Copy Markdown
Contributor Author

sollhui commented Oct 25, 2023

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.65 seconds
stream load tsv: 551 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162250055 Bytes

Copy link
Copy Markdown
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Oct 25, 2023
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

Copy link
Copy Markdown
Contributor

@jacktengg jacktengg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 235ae9d into apache:master Oct 25, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants