[improvement](insert) Modify insert into table_id(xxx) to doris_inter… by mymeiyi · Pull Request #25662 · apache/doris

mymeiyi · 2023-10-20T03:45:16Z

…nal_table_id(xxx)

Proposed changes

Modify keyword table_id to a special keyword doris_internal_table_id

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

mymeiyi · 2023-10-20T03:45:32Z

run buildall

github-actions · 2023-10-20T03:53:33Z

clang-tidy review says "All clean, LGTM! 👍"

zzzzzzzs · 2023-10-20T03:54:35Z

LGTM

doris-robot · 2023-10-20T04:15:29Z

TeamCity be ut coverage result:
Function Coverage: 36.98% (8285/22405)
Line Coverage: 29.07% (66459/228617)
Region Coverage: 27.73% (34502/124432)
Branch Coverage: 24.34% (17529/72016)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dddfe5b0c04f38f88484d290833810fd2f29d50d_dddfe5b0c04f38f88484d290833810fd2f29d50d/report/index.html

doris-robot · 2023-10-20T04:16:47Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.97 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162090459 Bytes

github-actions · 2023-10-20T04:46:16Z

PR approved by anyone and no changes requested.

dataroaring

LGTM

github-actions · 2023-10-20T05:25:58Z

PR approved by at least one committer and no changes requested.

…nal_table_id(xxx)

mymeiyi · 2023-10-20T06:08:50Z

run buildall

github-actions · 2023-10-20T06:16:50Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2023-10-20T07:23:31Z

TeamCity be ut coverage result:
Function Coverage: 37.04% (8299/22408)
Line Coverage: 29.16% (66669/228594)
Region Coverage: 27.81% (34596/124407)
Branch Coverage: 24.41% (17577/72018)
Coverage Report: http://coverage.selectdb-in.cc/coverage/32f2b9e86808aa9e455b82d700e24186c3c33e35_32f2b9e86808aa9e455b82d700e24186c3c33e35/report/index.html

doris-robot · 2023-10-20T07:43:47Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.27 seconds
stream load tsv: 551 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162064231 Bytes

morrySnow · 2023-10-20T08:05:46Z

fe/fe-core/src/main/cup/sql_parser.cup

    KW_DISTRIBUTION,
    KW_DIV,
    KW_DO,
+    KW_DORIS_INTERNAL_TABLE_ID,


should add into non-reserved keyword list, and add same keyword for Nereids in src/main/antlr4/org/apache/doris/nereids/DorisParser.g4

mymeiyi · 2023-10-20T08:49:22Z

run buildall

github-actions · 2023-10-20T08:56:50Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2023-10-20T09:17:54Z

TeamCity be ut coverage result:
Function Coverage: 37.03% (8299/22410)
Line Coverage: 29.19% (66674/228388)
Region Coverage: 27.82% (34601/124360)
Branch Coverage: 24.41% (17576/71996)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c3141627702907023847df4069cf9e059b6198e9_c3141627702907023847df4069cf9e059b6198e9/report/index.html

github-actions · 2023-10-20T09:20:23Z

clang-tidy review says "All clean, LGTM! 👍"

mymeiyi · 2023-10-20T09:21:51Z

run buildall

doris-robot · 2023-10-20T09:39:32Z

TeamCity be ut coverage result:
Function Coverage: 37.04% (8301/22410)
Line Coverage: 29.20% (66684/228388)
Region Coverage: 27.83% (34607/124360)
Branch Coverage: 24.41% (17577/71996)
Coverage Report: http://coverage.selectdb-in.cc/coverage/343407b9f0a37b84ec5661190e180182a3ef309e_343407b9f0a37b84ec5661190e180182a3ef309e/report/index.html

doris-robot · 2023-10-20T09:56:21Z

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.71 seconds
stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162370260 Bytes

mymeiyi · 2023-10-20T10:19:12Z

run p0

dataroaring

LGTM

github-actions · 2023-10-20T11:30:33Z

PR approved by at least one committer and no changes requested.

apache#25662)

zzzzzzzs approved these changes Oct 20, 2023

View reviewed changes

github-actions bot added the reviewed label Oct 20, 2023

dataroaring previously approved these changes Oct 20, 2023

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 20, 2023

[improvement](insert) Modify insert into table_id(xxx) to doris_inter…

32f2b9e

…nal_table_id(xxx)

mymeiyi dismissed dataroaring’s stale review via 32f2b9e October 20, 2023 06:08

mymeiyi force-pushed the rename branch from dddfe5b to 32f2b9e Compare October 20, 2023 06:08

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 20, 2023

morrySnow reviewed Oct 20, 2023

View reviewed changes

fix comments

343407b

mymeiyi force-pushed the rename branch from c314162 to 343407b Compare October 20, 2023 09:12

dataroaring approved these changes Oct 20, 2023

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 20, 2023

dataroaring merged commit fded8ba into apache:master Oct 20, 2023

dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023

[improvement](insert) Modify insert into table_id(xxx) to doris_inter… (

4a6ba12

apache#25662)

XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023

[improvement](insert) Modify insert into table_id(xxx) to doris_inter… (

d86a97d

apache#25662)

Comments

Conversation

mymeiyi commented Oct 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Further comments

Uh oh!

mymeiyi commented Oct 20, 2023

Uh oh!

github-actions bot commented Oct 20, 2023

Uh oh!

zzzzzzzs commented Oct 20, 2023

Uh oh!

doris-robot commented Oct 20, 2023

Uh oh!

doris-robot commented Oct 20, 2023

Uh oh!

github-actions bot commented Oct 20, 2023

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 20, 2023

Uh oh!

mymeiyi commented Oct 20, 2023

Uh oh!

github-actions bot commented Oct 20, 2023

Uh oh!

doris-robot commented Oct 20, 2023

Uh oh!

doris-robot commented Oct 20, 2023

Uh oh!

morrySnow Oct 20, 2023

Choose a reason for hiding this comment

Uh oh!

mymeiyi commented Oct 20, 2023

Uh oh!

github-actions bot commented Oct 20, 2023

Uh oh!

doris-robot commented Oct 20, 2023

Uh oh!

github-actions bot commented Oct 20, 2023

Uh oh!

mymeiyi commented Oct 20, 2023

Uh oh!

doris-robot commented Oct 20, 2023

Uh oh!

doris-robot commented Oct 20, 2023

Uh oh!

mymeiyi commented Oct 20, 2023

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mymeiyi commented Oct 20, 2023 •

edited

Loading