[fix](nereids) fix wrong result precision for add/sub#25751
[fix](nereids) fix wrong result precision for add/sub#25751morrySnow merged 1 commit intoapache:masterfrom
Conversation
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
afd22a7 to
1704dc4
Compare
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
| @Override | ||
| public DecimalV3Type getDataTypeForDecimalV3(DecimalV3Type t1, DecimalV3Type t2) { | ||
| return (DecimalV3Type) DecimalV3Type.widerDecimalV3Type(t1, t2, false); | ||
| return (DecimalV3Type) DecimalV3Type.widerDecimalV3TypeForAddSub(t1, t2, false); |
There was a problem hiding this comment.
do not change widerDecimalV3TypeForAddSub directly, use widerDecimalV3TypeForAddSub's result and plus 1 on its precision to create a new DecimalV3Type object
1704dc4 to
1bb1c94
Compare
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
1bb1c94 to
7b3f76f
Compare
|
run buildall |
|
run feut |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run feut |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...