[fix](tools) Fixing Date Type Issue in TPCDS Test Tool for Doris Table Creation #25887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
date to datev2
TOMATOFQY
changed the title
Contributor
|
We're closing this PR because it hasn't been updated in a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
date to datev2
Proposed changes
Issue Number: close #25886
After conducting local testing, simply modifying "date" to "datev2" in the SQL statement will successfully create the table.
Further comments
I am conducting a tpcds test on Doris, but I have found a slight issue with the tpcds test tool provided by Doris. Currently, I have noticed a problem with the table creation statement when the size factor is set to 1. In simple terms, the date type has not been modified to datev2 type. The table creation statements for other specifications were modified in a commit three months ago, but this specific issue was overlooked. I believe it was missed at that time.
After conducting local testing, simply modifying "date" to "datev2" in the SQL statement will successfully create the table. After conducting local testing, it was found that it can run on version 2.0.2.