Skip to content

[feature](Nereids): Convert topn(x, 1) to max(x)#26004

Merged
yiguolei merged 3 commits intoapache:masterfrom
jackwener:topn
Oct 27, 2023
Merged

[feature](Nereids): Convert topn(x, 1) to max(x)#26004
yiguolei merged 3 commits intoapache:masterfrom
jackwener:topn

Conversation

@jackwener
Copy link
Member

Proposed changes

Convert topn(x, 1) to max(x)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@wm1581066
Copy link

Any testcase?

@yiguolei yiguolei added usercase Important user case type label dev/2.0.3 labels Oct 27, 2023
@yiguolei
Copy link
Contributor

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.71 seconds
stream load tsv: 575 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17162266362 Bytes

@jackwener
Copy link
Member Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.14 seconds
stream load tsv: 577 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162194430 Bytes

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 27, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei merged commit d953e5c into apache:master Oct 27, 2023
@jackwener jackwener deleted the topn branch October 27, 2023 13:01
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
jackwener added a commit to jackwener/doris that referenced this pull request Nov 2, 2023
jackwener added a commit that referenced this pull request Nov 2, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Comments