Skip to content

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Oct 27, 2023

Proposed changes

In branch 2.0, we changed the read/write method of AnalysisManager,
and rename the image module name to AnalysisMgrV2.
So we need to make the same change in master branch, so that user
can upgrade Doris from branch-2.0 to master branch.

After this PR, user can:

  • upgrade from 2.0.x(or branch-2.0) to master

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 27, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Collaborator

@wm1581066 wm1581066 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.25 seconds
stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162180157 Bytes

@morningman morningman merged commit 1e5ed91 into apache:master Oct 29, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Nov 4, 2023
… later) (apache#26048)

In branch 2.0, we changed the read/write method of AnalysisManager,
and rename the image module name to AnalysisMgrV2.
So we need to make the same change in master branch, so that user
can upgrade Doris from branch-2.0 to master branch.

After this PR, user can:

- upgrade from 2.0.x(or branch-2.0) to master
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 13, 2023
… later) (apache#26048)

In branch 2.0, we changed the read/write method of AnalysisManager,
and rename the image module name to AnalysisMgrV2.
So we need to make the same change in master branch, so that user
can upgrade Doris from branch-2.0 to master branch.

After this PR, user can:

- upgrade from 2.0.x(or branch-2.0) to master
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
… later) (apache#26048)

In branch 2.0, we changed the read/write method of AnalysisManager,
and rename the image module name to AnalysisMgrV2.
So we need to make the same change in master branch, so that user
can upgrade Doris from branch-2.0 to master branch.

After this PR, user can:

- upgrade from 2.0.x(or branch-2.0) to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. meta-change reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants