[fix](move-memtable) fix DeltaWriterV2 profile use-after-free #26110
Conversation
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| Status DeltaWriterV2Map::close() { | ||
| Status DeltaWriterV2Map::close(RuntimeProfile* profile) { |
There was a problem hiding this comment.
warning: method 'close' can be made static [readability-convert-member-functions-to-static]
be/src/vec/sink/delta_writer_v2_pool.h:72:
- Status close(RuntimeProfile* profile);
+ static Status close(RuntimeProfile* profile);
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
run buildall |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
…#26110) The sink who creates the delta writer may be closed while other sinks still using this delta writer. The parent profile is deconstructed and when the last sink trying to update the profile, it will meet use-after-free. To address this issue, we record the profile number in delta writer, and the last sink who close the delta writer will create and update the profile.
…#26110) The sink who creates the delta writer may be closed while other sinks still using this delta writer. The parent profile is deconstructed and when the last sink trying to update the profile, it will meet use-after-free. To address this issue, we record the profile number in delta writer, and the last sink who close the delta writer will create and update the profile.
…#26110) The sink who creates the delta writer may be closed while other sinks still using this delta writer. The parent profile is deconstructed and when the last sink trying to update the profile, it will meet use-after-free. To address this issue, we record the profile number in delta writer, and the last sink who close the delta writer will create and update the profile.
4 participants
Proposed changes
The sink who creates the delta writer may be closed while other sinks still using this delta writer.
The parent profile is deconstructed and when the last sink trying to update the profile, it will meet use-after-free.
To address this issue, we record the profile number in delta writer,
and the last sink who close the delta writer will create and update the profile.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...