[Fix](thrift api) column should be converted if const before serialize to arrow format #26111
Conversation
…e to arrow format ``` select null; ``` The above sql from thrift api will cause crash in `write_column_to_arrow` since it's column const, we should convert to full column
eldenmoon
force-pushed
the
dev-thrift-null
branch
from
9074488 to
cb2a102
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
can you add a testcase |
such case is difficult to add， and i cant find any demo |
…e to arrow format (apache#26111) ``` select null; ``` The above sql from thrift api will cause crash in `write_column_to_arrow` since it's column const, we should convert to full column
…e to arrow format (apache#26111) ``` select null; ``` The above sql from thrift api will cause crash in `write_column_to_arrow` since it's column const, we should convert to full column
…e to arrow format (apache#26111) ``` select null; ``` The above sql from thrift api will cause crash in `write_column_to_arrow` since it's column const, we should convert to full column
…e to arrow format (apache#26111) (apache#26264) The sql `select null` from thrift api will cause crash in `write_column_to_arrow` since it's column const, we should convert to full column
…e to arrow format (apache#26111) ``` select null; ``` The above sql from thrift api will cause crash in `write_column_to_arrow` since it's column const, we should convert to full column
4 participants
Proposed changes
The above sql from thrift api will cause crash in
write_column_to_arrowsince it's column const,we should convert to full column
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...