Skip to content

[minor](fe) remove some used code #26182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
morningman wants to merge 3 commits into from
Closed

[minor](fe) remove some used code #26182

morningman wants to merge 3 commits into from

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Oct 31, 2023

No description provided.

@morningman morningman marked this pull request as ready for review October 31, 2023 15:44
@morningman
Copy link
Contributor Author

morningman commented Oct 31, 2023

run buildall

yiguolei
yiguolei previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 1, 2023
@yiguolei
Copy link
Contributor

yiguolei commented Nov 1, 2023

run buildall

@morningman
Copy link
Contributor Author

morningman commented Nov 2, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Nov 2, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.36 seconds
stream load tsv: 560 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162302568 Bytes

@morningman morningman closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei left review comments

Assignees

No one assigned

Labels

reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@morningman @yiguolei @doris-robot