Skip to content

[FIX](decimal)fix column is decimalv3 cast to decimalv2 make be core#26204

Merged
yiguolei merged 1 commit into
apache:masterfrom
amorynan:fix-decimalv3-cast-to-decimalv2
Nov 1, 2023
Merged

[FIX](decimal)fix column is decimalv3 cast to decimalv2 make be core#26204
yiguolei merged 1 commit into
apache:masterfrom
amorynan:fix-decimalv3-cast-to-decimalv2

Conversation

@amorynan
Copy link
Copy Markdown
Contributor

@amorynan amorynan commented Nov 1, 2023

Proposed changes

Issue Number: close #xxx
when after cast expr , block column is nullable, so decimalv2 serde should handle nullable

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@amorynan
Copy link
Copy Markdown
Contributor Author

amorynan commented Nov 1, 2023

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2023

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Copy Markdown
Contributor

@jacktengg jacktengg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2023

PR approved by anyone and no changes requested.

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.34% (8468/22681)
Line Coverage: 29.65% (68543/231157)
Region Coverage: 28.23% (35598/126111)
Branch Coverage: 25.10% (18224/72618)
Coverage Report: http://coverage.selectdb-in.cc/coverage/54ae62db70cd59a5d16dc8fa54883d705eb483cd_54ae62db70cd59a5d16dc8fa54883d705eb483cd/report/index.html

@doris-robot
Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.22 seconds
stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17162293497 Bytes

@amorynan
Copy link
Copy Markdown
Contributor Author

amorynan commented Nov 1, 2023

run external

Copy link
Copy Markdown
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@jacktengg jacktengg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Nov 1, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2023

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei merged commit f8a594c into apache:master Nov 1, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Nov 4, 2023
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 13, 2023
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants