Skip to content

[chore](file-reader) rm unused interface from generic reader#26205

Merged
dataroaring merged 1 commit into
apache:masterfrom
Hastyshell:rm-unused-reader-interface
Nov 1, 2023
Merged

[chore](file-reader) rm unused interface from generic reader#26205
dataroaring merged 1 commit into
apache:masterfrom
Hastyshell:rm-unused-reader-interface

Conversation

@Hastyshell
Copy link
Copy Markdown
Collaborator

@Hastyshell Hastyshell commented Nov 1, 2023

Proposed changes

As title.

@Hastyshell
Copy link
Copy Markdown
Collaborator Author

Hastyshell commented Nov 1, 2023

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 1, 2023

TeamCity be ut coverage result:
Function Coverage: 37.35% (8470/22678)
Line Coverage: 29.67% (68573/231125)
Region Coverage: 28.24% (35613/126101)
Branch Coverage: 25.11% (18234/72612)
Coverage Report: http://coverage.selectdb-in.cc/coverage/021cd14e0480837afc1c9a4c9ea1abee97c8167d_021cd14e0480837afc1c9a4c9ea1abee97c8167d/report/index.html

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 1, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.39 seconds
stream load tsv: 561 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17161990110 Bytes

dataroaring
dataroaring approved these changes Nov 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Nov 1, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 1, 2023

PR approved by anyone and no changes requested.

yiguolei
yiguolei approved these changes Nov 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit aafd537 into apache:master Nov 1, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Nov 4, 2023
@Hastyshell
[chore](file-reader) rm unused interface from generic reader (apache#…
2544667 
…26205)
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 13, 2023
@Hastyshell @seawinde
[chore](file-reader) rm unused interface from generic reader (apache#…
64899c1 
…26205)
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@Hastyshell
[chore](file-reader) rm unused interface from generic reader (apache#…
2831d85 
…26205)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@platoneko platoneko platoneko approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Hastyshell @doris-robot @yiguolei @platoneko @dataroaring