Skip to content

[FIX](decimalv3)Fix largeint literal cast to decimalv3#26370

Merged
xiaokang merged 2 commits intoapache:branch-2.0from
amorynan:fix-decimalv3-largint
Nov 3, 2023
Merged

[FIX](decimalv3)Fix largeint literal cast to decimalv3#26370
xiaokang merged 2 commits intoapache:branch-2.0from
amorynan:fix-decimalv3-largint

Conversation

@amorynan
Copy link
Copy Markdown
Contributor

@amorynan amorynan commented Nov 3, 2023

Proposed changes

pr : #26159
Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@amorynan
Copy link
Copy Markdown
Contributor Author

amorynan commented Nov 3, 2023

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 38.18% (7925/20757)
Line Coverage: 30.01% (64124/213667)
Region Coverage: 29.21% (33213/113687)
Branch Coverage: 25.04% (17069/68172)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a6ee0b85bf4874b80a6d654819d6d60dbc6f3caa_a6ee0b85bf4874b80a6d654819d6d60dbc6f3caa/report/index.html

@doris-robot
Copy link
Copy Markdown

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.58 seconds
stream load tsv: 573 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162509287 Bytes

@xiaokang xiaokang merged commit d16a434 into apache:branch-2.0 Nov 3, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants