Skip to content

[fix](export)build_key_ranges_and_filters should not change original range after executing extend_scan_key function #26462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caiconghui merged 1 commit into from
Nov 7, 2023
Merged

[fix](export)build_key_ranges_and_filters should not change original range after executing extend_scan_key function #26462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion be/src/exec/olap_scan_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,12 @@ Status OlapScanNode::build_key_ranges_and_filters() {

RETURN_IF_ERROR(std::visit(
[&](auto&& range) {
RETURN_IF_ERROR(_scan_keys.extend_scan_key(range, _max_scan_key_num,
// make a copy or range and pass to extend_scan_key, keep the range unchanged
// because extend_scan_key method may change the first parameter.
// but the original range may be converted to olap filters, if it's not an exact_range.
// related pr https://github.com/apache/doris/pull/13530
auto temp_range = range;
RETURN_IF_ERROR(_scan_keys.extend_scan_key(temp_range, _max_scan_key_num,
&exact_range, &eos));
if (exact_range) {
_column_value_ranges.erase(iter->first);
Expand Down