[fix](move-memtable) ensure segment is flushed before add segment#26522
[fix](move-memtable) ensure segment is flushed before add segment#26522dataroaring merged 3 commits intoapache:masterfrom
Conversation
|
run buildall |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| Status LoadStreamWriter::add_segment(uint32_t segid, SegmentStatistics& stat) { | ||
| Status LoadStreamWriter::add_segment(uint32_t segid, const SegmentStatistics& stat) { |
There was a problem hiding this comment.
warning: method 'add_segment' can be made static [readability-convert-member-functions-to-static]
be/src/runtime/load_stream_writer.h:73:
- Status add_segment(uint32_t segid, const SegmentStatistics& stat);
+ static Status add_segment(uint32_t segid, const SegmentStatistics& stat);
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
run buildall |
github-actions
bot
removed
the
approved
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
4 participants
Proposed changes
Currently segment flush is async, and ADD_SEGMENT is handled immediately.
When ADD_SEGMENT arrives, segment flush may not been finished, causing corruption.
Fix this issue by execute ADD_SEGMENT asyncly in the same FIFO threadpool of segment flush.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...