[only test] avoid_using_blocked_queue#26571
Conversation
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return Status::OK(); | ||
| } | ||
|
|
||
| void MultiCastDataStreamer::_set_ready_for_read(int sender_idx) { |
There was a problem hiding this comment.
warning: method '_set_ready_for_read' can be made const [readability-make-member-function-const]
| void MultiCastDataStreamer::_set_ready_for_read(int sender_idx) { | |
| void MultiCastDataStreamer::_set_ready_for_read(int sender_idx) const { |
be/src/pipeline/exec/multi_cast_data_streamer.h:79:
- void _set_ready_for_read(int sender_idx);
+ void _set_ready_for_read(int sender_idx) const;| dep->set_ready_for_read(); | ||
| } | ||
|
|
||
| void MultiCastDataStreamer::_set_ready_for_read() { |
There was a problem hiding this comment.
warning: method '_set_ready_for_read' can be made const [readability-make-member-function-const]
| void MultiCastDataStreamer::_set_ready_for_read() { | |
| void MultiCastDataStreamer::_set_ready_for_read() const { |
be/src/pipeline/exec/multi_cast_data_streamer.h:80:
- void _set_ready_for_read();
+ void _set_ready_for_read() const;| } | ||
| } | ||
|
|
||
| void MultiCastDataStreamer::_block_reading(int sender_idx) { |
There was a problem hiding this comment.
warning: method '_block_reading' can be made const [readability-make-member-function-const]
| void MultiCastDataStreamer::_block_reading(int sender_idx) { | |
| void MultiCastDataStreamer::_block_reading(int sender_idx) const { |
be/src/pipeline/exec/multi_cast_data_streamer.h:81:
- void _block_reading(int sender_idx);
+ void _block_reading(int sender_idx) const;| dep->set_ready_for_read(); | ||
| } | ||
| } | ||
| void set_dep_by_channel_id(Dependency* dep, int channel_id) { |
There was a problem hiding this comment.
warning: method 'set_dep_by_channel_id' can be made static [readability-convert-member-functions-to-static]
| void set_dep_by_channel_id(Dependency* dep, int channel_id) { | |
| static void set_dep_by_channel_id(Dependency* dep, int channel_id) { |
| source_dependencies[channel_id] = dep; | ||
| dep->block_reading(); | ||
| } | ||
| void _set_ready_for_read(int channel_id) { |
There was a problem hiding this comment.
warning: method '_set_ready_for_read' can be made static [readability-convert-member-functions-to-static]
| void _set_ready_for_read(int channel_id) { | |
| static void _set_ready_for_read(int channel_id) { |
| // must be call after all pipeline task is finish to release resource | ||
| Status close(Status exec_status) override; | ||
|
|
||
| Dependency* read_blocked_dependency() { |
There was a problem hiding this comment.
warning: method 'read_blocked_dependency' can be made static [readability-convert-member-functions-to-static]
| Dependency* read_blocked_dependency() { | |
| static Dependency* read_blocked_dependency() { |
| std::string debug_string() override; | ||
|
|
||
| bool is_pending_finish() override { | ||
| Dependency* finish_blocked_dependency() { |
There was a problem hiding this comment.
warning: method 'finish_blocked_dependency' can be made static [readability-convert-member-functions-to-static]
| Dependency* finish_blocked_dependency() { | |
| static Dependency* finish_blocked_dependency() { |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
Mryange
force-pushed
the
pipelineX-dep15
branch
from
027b02f to
d03afb9
Compare
2 participants
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...