Skip to content

Conversation

@kobe6th
Copy link
Contributor

@kobe6th kobe6th commented Nov 9, 2023

Proposed changes

Issue Number: close #26667
ref: #17989
fix same issue on branch-1.2-lts

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@kobe6th kobe6th force-pushed the branch-1.2-lts-large-string-column branch from b7cf703 to a4fda01 Compare November 9, 2023 13:04
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 10, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei
Copy link
Contributor

Not merge it.
Because 1.2 is not exception safe. If you throw exception here, there maybe memory leak.

@yiguolei yiguolei closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/vectorization kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants