Skip to content

Conversation

@airborne12
Copy link
Member

Proposed changes

Issue Number: close #xxx

Pick from #26689

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@airborne12
Copy link
Member Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.35% (7966/20773)
Line Coverage: 30.19% (64628/214069)
Region Coverage: 29.26% (33321/113894)
Branch Coverage: 25.08% (17122/68278)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1b3ff8108cf0f13b063f7edf4a74bc807889b0d2_1b3ff8108cf0f13b063f7edf4a74bc807889b0d2/report/index.html

@xiaokang xiaokang marked this pull request as draft November 13, 2023 09:16
@xiaokang
Copy link
Contributor

delay to 2.0.4

@airborne12
Copy link
Member Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.34% (7964/20773)
Line Coverage: 30.16% (64563/214073)
Region Coverage: 29.22% (33280/113890)
Branch Coverage: 25.04% (17095/68272)
Coverage Report: http://coverage.selectdb-in.cc/coverage/47350d4d44b31c8fd71e81fa5098a5f33679a7f9_47350d4d44b31c8fd71e81fa5098a5f33679a7f9/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.68 seconds
stream load tsv: 558 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162556271 Bytes

@airborne12 airborne12 marked this pull request as ready for review December 1, 2023 01:12
@airborne12
Copy link
Member Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.94% (7982/21039)
Line Coverage: 29.63% (64716/218393)
Region Coverage: 29.08% (33345/114682)
Branch Coverage: 24.93% (17118/68672)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0fe00d3dee3d9d4e5b5b96f4eb7a57bb4541c3b5_0fe00d3dee3d9d4e5b5b96f4eb7a57bb4541c3b5/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.91 seconds
stream load tsv: 582 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.9 seconds inserted 10000000 Rows, about 334K ops/s
storage size: 17164282093 Bytes

Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 11, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@xiaokang xiaokang merged commit a6bf4ee into apache:branch-2.0 Dec 11, 2023
@airborne12 airborne12 changed the title [Pick-2.0](segment iterator) remove range in first read to save time [Pick 2.0](segment iterator) remove range in first read to save time Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants