Skip to content

Comments

[chore](docker cases): support for specifying output from the command line#27340

Merged
dataroaring merged 1 commit intoapache:masterfrom
feifeifeimoon:master
Nov 23, 2023
Merged

[chore](docker cases): support for specifying output from the command line#27340
dataroaring merged 1 commit intoapache:masterfrom
feifeifeimoon:master

Conversation

@feifeifeimoon
Copy link
Contributor

@feifeifeimoon feifeifeimoon commented Nov 21, 2023

Build image in pipeline
docker build --build-arg OUT_DIRECTORY=. -f Dockerfile -t xx-doris:asan /path/to/doris/output

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@feifeifeimoon feifeifeimoon changed the title [chore](docker cases): support for specifying output from the command… [chore](docker cases): support for specifying output from the command line Nov 21, 2023
Copy link
Contributor

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 23, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 78203c8 into apache:master Nov 23, 2023
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 28, 2023
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants