Skip to content

[pipelineX](minor) remove unused code#27446

Merged
Gabriel39 merged 1 commit intoapache:masterfrom
Gabriel39:minor_1123
Nov 23, 2023
Merged

[pipelineX](minor) remove unused code#27446
Gabriel39 merged 1 commit intoapache:masterfrom
Gabriel39:minor_1123

Conversation

@Gabriel39
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit 115186de45a6434d4a516cae0122d479afdc0944, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4935	4640	4659	4640
q2	355	147	141	141
q3	2033	1963	1957	1957
q4	1388	1284	1242	1242
q5	3958	3966	4056	3966
q6	251	129	133	129
q7	1426	883	902	883
q8	2785	2794	2777	2777
q9	9650	10064	9456	9456
q10	3485	3546	3510	3510
q11	375	252	256	252
q12	438	291	292	291
q13	4576	3791	3817	3791
q14	326	282	278	278
q15	585	540	517	517
q16	659	581	590	581
q17	1151	968	955	955
q18	7881	7523	7470	7470
q19	1690	1704	1703	1703
q20	535	298	292	292
q21	4446	3991	4003	3991
q22	467	378	373	373
Total cold run time: 53395 ms
Total hot run time: 49195 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4591	4591	4584	4584
q2	343	234	239	234
q3	4039	3991	3982	3982
q4	2714	2709	2699	2699
q5	9582	9545	9573	9545
q6	248	120	125	120
q7	3031	2476	2440	2440
q8	4451	4425	4458	4425
q9	12982	12884	12827	12827
q10	4174	4175	4173	4173
q11	850	635	669	635
q12	980	818	810	810
q13	4327	3559	3574	3559
q14	396	358	345	345
q15	577	521	517	517
q16	739	712	671	671
q17	3892	3895	3876	3876
q18	9551	9047	9098	9047
q19	1790	1800	1770	1770
q20	2406	2083	2065	2065
q21	8916	8423	8512	8423
q22	889	816	802	802
Total cold run time: 81468 ms
Total hot run time: 77549 ms

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.15 seconds
stream load tsv: 567 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17097447430 Bytes

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.56% (8447/23105)
Line Coverage: 28.85% (68652/237938)
Region Coverage: 27.82% (35506/127628)
Branch Coverage: 24.56% (18117/73762)
Coverage Report: http://coverage.selectdb-in.cc/coverage/115186de45a6434d4a516cae0122d479afdc0944_115186de45a6434d4a516cae0122d479afdc0944/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 23, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit 75d1594 into apache:master Nov 23, 2023
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 28, 2023
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments