Skip to content

[improvement](nereids) add config for nereids trace dir #27495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Nov 25, 2023
Merged

[improvement](nereids) add config for nereids trace dir #27495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/en/docs/admin-manual/config/fe-config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1728,6 +1728,12 @@ Default: false

If true, will compress fe.audit.log by gzip

#### `nereids_trace_log_dir`

Default: DorisFE.DORIS_HOME_DIR + "/log/nereids_trace"

Used to specify the directory of the nereids trace log

### Storage

#### `min_replication_num_per_tablet`
Expand Down
6 changes: 6 additions & 0 deletions docs/zh-CN/docs/admin-manual/config/fe-config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1728,6 +1728,12 @@ HOUR: log前缀是：yyyyMMddHH

控制是否压缩 fe.audit.log。如果开启，则使用gzip算法进行压缩。

#### `nereids_trace_log_dir`

默认值：DorisFE.DORIS_HOME_DIR + "/log/nereids_trace"

用于存储 nereids trace 日志的目录

### 存储

#### `min_replication_num_per_tablet`
Expand Down
4 changes: 4 additions & 0 deletions fe/fe-common/src/main/java/org/apache/doris/common/Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2293,4 +2293,8 @@ public class Config extends ConfigBase {
+ "If it is less than this value, it will be diagnosed as balanced."
})
public static double diagnose_balance_max_tablet_num_ratio = 1.1;

@ConfField(description = {"nereids trace文件的存放路径。",
"The path of the nereids trace file."})
public static String nereids_trace_log_dir = System.getenv("DORIS_HOME") + "/log/nereids_trace";
}
3 changes: 2 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/nereids/minidump/NereidsTracer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.doris.nereids.minidump;

import org.apache.doris.common.Config;
import org.apache.doris.common.util.DebugUtil;
import org.apache.doris.common.util.TimeUtils;
import org.apache.doris.nereids.cost.Cost;
Expand Down Expand Up @@ -172,7 +173,7 @@ public static void output(ConnectContext connectContext) {
public static void init() {
NereidsTracer.shouldLog = true;
startTime = TimeUtils.getStartTimeMs();
TRACE_PATH = Optional.ofNullable(TRACE_PATH).orElse(System.getenv("DORIS_HOME") + "/log/nereids_trace");
TRACE_PATH = Optional.ofNullable(TRACE_PATH).orElse(Config.nereids_trace_log_dir);
new File(TRACE_PATH).mkdirs();
}
}
Expand Down