-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[enhancement](stats) Stats auto collector execute in serial #27634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
| analysisTasks.values().forEach(analysisTaskExecutor::submitTask); | ||
| for (BaseAnalysisTask task : analysisTasks.values()) { | ||
| try { | ||
| task.execute(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a block. But it's better to write the successfully executed tasks' result to column statistics table, instead of fail the whole job when one task failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree with you and the logic you mentioned has been implemented in AnalysisJob
|
PR approved by anyone and no changes requested. |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...