-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[WIP][pipelineX](local shuffle) Use local shuffle to optimize BHJ #27823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
| return _sub_plan_query_statistics_recvr; | ||
| } | ||
|
|
||
| bool need_to_local_shuffle() const override { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: method 'need_to_local_shuffle' can be made static [readability-convert-member-functions-to-static]
| bool need_to_local_shuffle() const override { | |
| static bool need_to_local_shuffle() override { |
| return Status::OK(); | ||
| } | ||
|
|
||
| Status PipelineXFragmentContext::_plan_local_shuffle() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: method '_plan_local_shuffle' can be made static [readability-convert-member-functions-to-static]
be/src/pipeline/pipeline_x/pipeline_x_fragment_context.h:155:
- Status _plan_local_shuffle();
+ static Status _plan_local_shuffle();|
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
yiguolei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...