Skip to content

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Dec 6, 2023

Proposed changes

Issue Number: close #xxx

support sql:

DELETE FROM <table_name> WHERE <predicates>

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.89 seconds
stream load tsv: 589 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17193781940 Bytes

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit 566c27c367dcd0923cb68e78acce65edb53e3146, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4681	4406	4506	4406
q2	366	176	159	159
q3	1463	1254	1199	1199
q4	1118	944	931	931
q5	3191	3183	3186	3183
q6	249	129	127	127
q7	1007	491	498	491
q8	2195	2253	2215	2215
q9	6683	6692	6664	6664
q10	3203	3268	3263	3263
q11	327	214	210	210
q12	347	218	213	213
q13	4548	3811	3821	3811
q14	240	217	209	209
q15	570	520	523	520
q16	442	397	391	391
q17	1006	613	601	601
q18	7769	7917	7113	7113
q19	1526	1339	1418	1339
q20	633	347	342	342
q21	3103	2620	2684	2620
q22	351	289	292	289
Total cold run time: 45018 ms
Total hot run time: 40296 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4374	4374	4353	4353
q2	274	164	172	164
q3	3534	3516	3518	3516
q4	2403	2385	2379	2379
q5	5742	5745	5723	5723
q6	240	122	124	122
q7	2400	1842	1882	1842
q8	3520	3523	3527	3523
q9	9098	9031	9010	9010
q10	3904	3991	4016	3991
q11	496	369	388	369
q12	770	581	583	581
q13	4290	3572	3553	3553
q14	282	249	257	249
q15	567	522	513	513
q16	512	472	468	468
q17	1860	1850	1848	1848
q18	8793	9007	8410	8410
q19	1739	1744	1730	1730
q20	2248	1950	1923	1923
q21	6539	6176	6176	6176
q22	517	412	422	412
Total cold run time: 64102 ms
Total hot run time: 60855 ms

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.02 seconds
stream load tsv: 584 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17193492250 Bytes

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit 715353909fc972b56330ad866abe26597c7ee1b8, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4711	4442	4477	4442
q2	371	178	156	156
q3	1459	1258	1233	1233
q4	1124	961	912	912
q5	3181	3207	3198	3198
q6	250	134	125	125
q7	984	507	505	505
q8	2226	2242	2180	2180
q9	6660	6742	6687	6687
q10	3219	3243	3259	3243
q11	327	204	206	204
q12	360	211	214	211
q13	4568	3802	3815	3802
q14	250	222	216	216
q15	578	519	520	519
q16	442	401	387	387
q17	1013	624	604	604
q18	7857	7482	6970	6970
q19	1531	1375	1421	1375
q20	558	346	313	313
q21	3141	2694	2702	2694
q22	366	292	296	292
Total cold run time: 45176 ms
Total hot run time: 40268 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4404	4395	4402	4395
q2	267	161	168	161
q3	3547	3543	3530	3530
q4	2393	2402	2376	2376
q5	5775	5724	5754	5724
q6	242	122	121	121
q7	2390	1860	1863	1860
q8	3527	3518	3529	3518
q9	9016	9058	9046	9046
q10	3901	4006	3983	3983
q11	504	373	388	373
q12	763	606	608	606
q13	4273	3529	3571	3529
q14	283	262	256	256
q15	569	518	518	518
q16	500	460	465	460
q17	1872	1871	1848	1848
q18	8636	9087	8494	8494
q19	1713	1773	1744	1744
q20	2263	1940	1921	1921
q21	6558	6204	6145	6145
q22	506	420	431	420
Total cold run time: 63902 ms
Total hot run time: 61028 ms

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.77 seconds
stream load tsv: 578 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17212118007 Bytes

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit 56873d8b632e96f6df1c1c7a2aab9f2821292331, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4689	4399	4471	4399
q2	362	152	158	152
q3	1451	1246	1238	1238
q4	1122	941	941	941
q5	3143	3153	3150	3150
q6	248	129	127	127
q7	980	501	492	492
q8	2199	2197	2195	2195
q9	6679	6707	6696	6696
q10	3219	3268	3266	3266
q11	321	206	203	203
q12	351	208	212	208
q13	4554	3776	3783	3776
q14	240	214	218	214
q15	564	525	523	523
q16	434	402	384	384
q17	1007	599	556	556
q18	7607	7748	6956	6956
q19	1526	1413	1406	1406
q20	627	304	326	304
q21	3086	2689	2636	2636
q22	357	284	292	284
Total cold run time: 44766 ms
Total hot run time: 40106 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4417	4417	4394	4394
q2	265	161	170	161
q3	3526	3522	3517	3517
q4	2380	2358	2355	2355
q5	5762	5717	5750	5717
q6	240	122	122	122
q7	2383	1863	1856	1856
q8	3516	3524	3527	3524
q9	9015	8984	8982	8982
q10	3900	3976	3999	3976
q11	509	387	376	376
q12	754	597	607	597
q13	4285	3549	3553	3549
q14	285	247	263	247
q15	565	550	521	521
q16	501	453	443	443
q17	1856	1840	1869	1840
q18	8715	8219	8358	8219
q19	1708	1742	1745	1742
q20	2269	1936	1922	1922
q21	6487	6150	6149	6149
q22	501	422	405	405
Total cold run time: 63839 ms
Total hot run time: 60614 ms

@morrySnow
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit 6b92682c83f33bc4a130bc8428df49d916e811e2, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4720	4443	4496	4443
q2	367	161	157	157
q3	1451	1280	1240	1240
q4	1109	941	869	869
q5	3147	3134	3161	3134
q6	250	130	126	126
q7	984	483	482	482
q8	2207	2252	2207	2207
q9	6671	6662	6713	6662
q10	3221	3255	3272	3255
q11	323	204	200	200
q12	355	209	200	200
q13	4625	3788	3787	3787
q14	245	208	218	208
q15	576	522	519	519
q16	439	391	394	391
q17	1012	600	583	583
q18	7818	7205	6894	6894
q19	1512	1409	1413	1409
q20	548	309	347	309
q21	3102	2624	2708	2624
q22	347	278	279	278
Total cold run time: 45029 ms
Total hot run time: 39977 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4408	4386	4402	4386
q2	270	164	174	164
q3	3535	3550	3528	3528
q4	2393	2389	2397	2389
q5	5735	5736	5741	5736
q6	239	121	123	121
q7	2394	1848	1855	1848
q8	3523	3533	3527	3527
q9	9116	9066	9058	9058
q10	3927	4021	4008	4008
q11	510	377	400	377
q12	757	598	598	598
q13	4307	3536	3542	3536
q14	278	250	251	250
q15	574	520	514	514
q16	500	463	469	463
q17	1886	1878	1908	1878
q18	8683	8154	8341	8154
q19	1759	1727	1776	1727
q20	2282	1963	2021	1963
q21	6787	6289	6169	6169
q22	506	412	443	412
Total cold run time: 64369 ms
Total hot run time: 60806 ms

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.95 seconds
stream load tsv: 588 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17214754293 Bytes

@morrySnow
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.18 seconds
stream load tsv: 596 seconds loaded 74807831229 Bytes, about 119 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17213677969 Bytes

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit ac66fda0955e5e7560635ed00c0230d036aedde1, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4722	4434	4489	4434
q2	364	174	155	155
q3	1454	1210	1231	1210
q4	1104	924	887	887
q5	3136	3128	3156	3128
q6	246	130	128	128
q7	971	489	481	481
q8	2156	2224	2141	2141
q9	6638	6608	6645	6608
q10	3211	3246	3281	3246
q11	324	205	199	199
q12	351	211	213	211
q13	4565	3847	3803	3803
q14	237	209	209	209
q15	571	520	523	520
q16	453	389	386	386
q17	996	566	535	535
q18	7401	6976	6859	6859
q19	1515	1355	1386	1355
q20	1225	427	287	287
q21	3043	2616	2648	2616
q22	338	286	283	283
Total cold run time: 45021 ms
Total hot run time: 39681 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4391	4370	4359	4359
q2	266	165	173	165
q3	3514	3520	3511	3511
q4	2361	2368	2353	2353
q5	5730	5713	5718	5713
q6	241	121	120	120
q7	2370	1906	1890	1890
q8	3463	3489	3482	3482
q9	9050	9026	8967	8967
q10	3904	3953	3969	3953
q11	494	394	389	389
q12	761	604	602	602
q13	4283	3559	3587	3559
q14	276	255	250	250
q15	564	523	522	522
q16	499	456	459	456
q17	1872	1836	1842	1836
q18	8620	8312	8435	8312
q19	1713	1707	1735	1707
q20	2244	1949	1936	1936
q21	6474	6143	6135	6135
q22	503	420	425	420
Total cold run time: 63593 ms
Total hot run time: 60637 ms

@morrySnow morrySnow force-pushed the delete_partition branch 2 times, most recently from 8dc9d56 to 1ac789d Compare December 11, 2023 12:59
@morrySnow
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit 1ac789d4d96c269dc5f22a00b59624e11f3e7960, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4765	4507	4518	4507
q2	369	144	168	144
q3	1468	1267	1218	1218
q4	1109	857	906	857
q5	3148	3144	3125	3125
q6	255	131	126	126
q7	1028	503	484	484
q8	2208	2216	2175	2175
q9	6644	6708	6662	6662
q10	3216	3263	3275	3263
q11	333	206	203	203
q12	356	205	216	205
q13	4574	5886	3829	3829
q14	244	212	218	212
q15	560	526	513	513
q16	444	388	401	388
q17	1002	584	571	571
q18	7848	7740	7638	7638
q19	1516	1366	1470	1366
q20	533	309	343	309
q21	3097	2671	2699	2671
q22	348	284	295	284
Total cold run time: 45065 ms
Total hot run time: 40750 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4469	4447	4456	4447
q2	266	162	175	162
q3	3579	3549	3550	3549
q4	2389	2387	2373	2373
q5	5756	5762	5765	5762
q6	243	119	120	119
q7	2412	1862	1910	1862
q8	3515	3533	3517	3517
q9	9062	9006	9059	9006
q10	3895	3982	4005	3982
q11	503	406	407	406
q12	768	600	624	600
q13	4299	3553	3554	3553
q14	292	256	253	253
q15	576	516	515	515
q16	506	471	495	471
q17	1875	1851	1818	1818
q18	8763	8761	8412	8412
q19	1756	1760	1755	1755
q20	2262	1943	1940	1940
q21	6543	6189	6184	6184
q22	511	428	436	428
Total cold run time: 64240 ms
Total hot run time: 61114 ms

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.12 seconds
stream load tsv: 589 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17219649255 Bytes

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow morrySnow added the not-merge/2.0 do not merge into 2.0 branch label Dec 12, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.73 seconds
stream load tsv: 578 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.0 seconds inserted 10000000 Rows, about 357K ops/s
storage size: 17217984303 Bytes

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit 3bb51c867f97eafcc9e77b9acd1a8cc09ef0b0df, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4707	4447	4459	4447
q2	363	168	158	158
q3	1464	1262	1217	1217
q4	1102	934	893	893
q5	3170	3152	3150	3150
q6	249	130	129	129
q7	1000	482	483	482
q8	2212	2234	2206	2206
q9	6713	38895	6712	6712
q10	10500	3271	3253	3253
q11	355	198	211	198
q12	530	204	206	204
q13	5035	3811	3798	3798
q14	252	213	216	213
q15	576	524	520	520
q16	469	389	396	389
q17	1012	592	587	587
q18	7586	6938	6812	6812
q19	1546	1408	1364	1364
q20	520	328	924	328
q21	3999	2648	2606	2606
q22	346	285	287	285
Total cold run time: 53706 ms
Total hot run time: 39951 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4461	4433	4412	4412
q2	269	160	175	160
q3	3512	3475	3504	3475
q4	2382	2372	2364	2364
q5	5745	5718	5712	5712
q6	237	123	123	123
q7	2375	1850	1826	1826
q8	3505	3525	3506	3506
q9	9083	9029	8959	8959
q10	3914	4020	4005	4005
q11	506	402	380	380
q12	769	585	592	585
q13	4291	3605	3570	3570
q14	294	260	252	252
q15	582	522	521	521
q16	505	463	503	463
q17	1862	1843	1821	1821
q18	8541	8011	8350	8011
q19	1746	1731	1728	1728
q20	2253	1950	1946	1946
q21	6479	6135	6113	6113
q22	497	423	420	420
Total cold run time: 63808 ms
Total hot run time: 60352 ms

@morrySnow
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.55 seconds
stream load tsv: 589 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.4 seconds inserted 10000000 Rows, about 352K ops/s
storage size: 17219553876 Bytes

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit 5577d648a159a2db5b0343220265d87e6aac5338, data reload: false

run tpch-sf100 query with default conf and session variables
q1	50214	31819	31842	31819
q2	371	136	143	136
q3	1536	1221	1201	1201
q4	1110	908	918	908
q5	3232	3225	3289	3225
q6	262	145	149	145
q7	1010	500	483	483
q8	2143	2219	2181	2181
q9	6948	6897	6902	6897
q10	3247	3295	3305	3295
q11	343	209	199	199
q12	348	205	206	205
q13	4552	3822	3781	3781
q14	437	317	327	317
q15	763	1306	1342	1306
q16	434	397	383	383
q17	1012	568	609	568
q18	7374	7292	6933	6933
q19	2693	1318	1444	1318
q20	1425	346	306	306
q21	3065	2672	2666	2666
q22	350	284	291	284
Total cold run time: 92869 ms
Total hot run time: 68556 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	30825	31854	31806	31806
q2	276	164	175	164
q3	3691	3620	3594	3594
q4	2376	2361	2350	2350
q5	5780	5795	5793	5793
q6	239	142	129	129
q7	3049	3416	3365	3365
q8	3536	3521	3526	3521
q9	9184	9138	9172	9138
q10	3979	4069	4050	4050
q11	840	887	1378	887
q12	774	585	599	585
q13	4328	3578	3565	3565
q14	487	454	458	454
q15	1107	1343	1327	1327
q16	512	456	466	456
q17	1874	1834	1843	1834
q18	8963	8979	8244	8244
q19	1758	1761	1745	1745
q20	2938	2600	2714	2600
q21	6545	6143	6139	6139
q22	501	415	427	415
Total cold run time: 93562 ms
Total hot run time: 92161 ms

@morrySnow
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.97 seconds
stream load tsv: 586 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.6 seconds inserted 10000000 Rows, about 349K ops/s
storage size: 17219394755 Bytes

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit b8f439de39964b41626f37e373999dba2337713c, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4746	4416	4509	4416
q2	364	150	139	139
q3	1484	1189	1229	1189
q4	1117	917	935	917
q5	3199	3224	3231	3224
q6	244	129	129	129
q7	1009	492	477	477
q8	2229	2258	2174	2174
q9	6703	6662	6650	6650
q10	3235	3284	3260	3260
q11	315	210	207	207
q12	357	212	220	212
q13	4543	3846	3792	3792
q14	241	211	221	211
q15	573	522	528	522
q16	448	395	388	388
q17	1011	662	569	569
q18	7050	6758	6809	6758
q19	1542	1514	1323	1323
q20	526	331	300	300
q21	3070	2598	2704	2598
q22	351	287	288	287
Total cold run time: 44357 ms
Total hot run time: 39742 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4415	4447	4441	4441
q2	282	166	177	166
q3	3529	3518	3512	3512
q4	2398	2387	2378	2378
q5	5743	5732	5737	5732
q6	238	125	122	122
q7	2349	1872	1862	1862
q8	3527	3526	3542	3526
q9	9089	9051	9021	9021
q10	3920	4032	4011	4011
q11	512	400	407	400
q12	775	600	586	586
q13	4316	3556	3544	3544
q14	285	250	251	250
q15	578	519	519	519
q16	511	445	484	445
q17	1886	1861	1882	1861
q18	8560	8119	7968	7968
q19	1750	1779	1736	1736
q20	2254	1946	1934	1934
q21	6526	6199	6171	6171
q22	509	419	416	416
Total cold run time: 63952 ms
Total hot run time: 60601 ms

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 14, 2023
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit bb23078 into apache:master Dec 14, 2023
@morrySnow morrySnow deleted the delete_partition branch December 14, 2023 05:54
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 12, 2024
support sql: DELETE FROM <table_name> WHERE <predicates>
Comment on lines +65 to +67
| explain? cte? DELETE FROM tableName=multipartIdentifier
partitionSpec? tableAlias
(USING relation (COMMA relation)*)?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we change the order of tableAlias and partitionSpec? the modified syntax does not follow the documentation and introduces compatibility issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. not-merge/2.0 do not merge into 2.0 branch reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants