[improve](env) Ensure next majority is met before drop an alive follower#28101
Merged
yiguolei merged 1 commit intoapache:masterfrom Dec 8, 2023
Merged
Conversation
Contributor
Author
|
run buildall |
| for (Frontend fe : frontends.values()) { | ||
| if (fe.getRole() == FrontendNodeType.FOLLOWER) { | ||
| numFollower += 1; | ||
| if (fe.isAlive()) { |
Contributor
There was a problem hiding this comment.
Alive status is set by heart mgr, the latency time is 5 seconds, In some situation, it can not detect fe is down ?
Contributor
Author
There was a problem hiding this comment.
Yes, this is only responsible for intercepting common cases. Some extreme cases cannot be guaranteed.
w41ter
force-pushed
the
improve/check_quorum_before_drop_frontend
branch
from
5662195 to
6a9cdbc
Compare
Contributor
Author
|
run buildall |
Here is an example: ``` mysql> ALTER SYSTEM DROP FOLLOWER "127.0.0.1:19017"; ERROR 1105 (HY000): errCode = 2, detailMessage = Unable to drop this alive follower, because the quorum requirements are not met after this command execution. Current num alive followers 2, num followers 3, majority after execution 2 ```
w41ter
force-pushed
the
improve/check_quorum_before_drop_frontend
branch
from
6a9cdbc to
5283adf
Compare
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
swjtu-zhanglei
approved these changes
Dec 8, 2023
XuJianxu
pushed a commit
to XuJianxu/doris
that referenced
this pull request
Dec 14, 2023
…wer (apache#28101) Here is an example: ``` mysql> ALTER SYSTEM DROP FOLLOWER "127.0.0.1:19017"; ERROR 1105 (HY000): errCode = 2, detailMessage = Unable to drop this alive follower, because the quorum requirements are not met after this command execution. Current num alive followers 2, num followers 3, majority after execution 2 ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Here is an example:
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...