Skip to content

[branch-2.0](memory) Fix disable segment cache#28169

Merged
yiguolei merged 1 commit intoapache:branch-2.0from
xinyiZzz:branch-2.0_fix_20231206_pick_disable_segment_cache
Dec 8, 2023
Merged

[branch-2.0](memory) Fix disable segment cache#28169
yiguolei merged 1 commit intoapache:branch-2.0from
xinyiZzz:branch-2.0_fix_20231206_pick_disable_segment_cache

Conversation

@xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Dec 8, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Dec 8, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.81% (7983/21115)
Line Coverage: 29.52% (64820/219558)
Region Coverage: 28.99% (33347/115027)
Branch Coverage: 24.90% (17125/68786)
Coverage Report: http://coverage.selectdb-in.cc/coverage/846d2b43ec136cb31b00b82753d55f774c6af59b_846d2b43ec136cb31b00b82753d55f774c6af59b/report/index.html

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 1f0111e into apache:branch-2.0 Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.4-merged p0_b reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants