Skip to content

[compile](plugin) Revert "[Improvement](auditlog) add column catalog for audit log and audit log table" #28177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Dec 8, 2023
Merged

[compile](plugin) Revert "[Improvement](auditlog) add column catalog for audit log and audit log table" #28177

yiguolei merged 1 commit into from
Dec 8, 2023

Conversation

@zhiqiang-hhhh
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh commented Dec 8, 2023 •
edited
Loading

Reverts #26403

This PR introduced plugin compile problem, many users suffer from this.

@zhiqiang-hhhh zhiqiang-hhhh changed the title Revert "[Improvement](auditlog) add column catalog for audit log and audit log table" [compile](plugin) Revert "[Improvement](auditlog) add column catalog for audit log and audit log table" Dec 8, 2023
@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Dec 8, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Dec 8, 2023

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' 
Tpch sf100 test result on commit 8fefc00273183a3b5a875c5634fc7125ee971087, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4716	4469	4455	4455
q2	367	154	162	154
q3	1460	1263	1197	1197
q4	1119	914	854	854
q5	3131	3132	3136	3132
q6	250	128	128	128
q7	996	478	473	473
q8	2197	2240	2196	2196
q9	6626	6647	6653	6647
q10	3220	3268	3275	3268
q11	317	194	194	194
q12	359	199	202	199
q13	4543	5749	3826	3826
q14	235	210	212	210
q15	570	527	526	526
q16	442	397	387	387
q17	1006	561	573	561
q18	7441	7035	6976	6976
q19	1556	1408	1400	1400
q20	520	308	303	303
q21	3012	2641	2601	2601
q22	352	285	288	285
Total cold run time: 44435 ms
Total hot run time: 39972 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4415	4370	4416	4370
q2	269	163	172	163
q3	3542	3526	3528	3526
q4	2375	2356	2357	2356
q5	5741	5762	5751	5751
q6	240	121	122	121
q7	2381	1874	1855	1855
q8	3655	3528	3524	3524
q9	9000	9015	8986	8986
q10	3924	3994	4011	3994
q11	487	392	377	377
q12	783	600	623	600
q13	4290	3577	3555	3555
q14	289	257	260	257
q15	567	521	528	521
q16	502	489	464	464
q17	1879	1841	1881	1841
q18	8620	8394	9690	8394
q19	1751	1752	1768	1752
q20	2252	1953	1942	1942
q21	6562	6224	6201	6201
q22	509	456	429	429
Total cold run time: 64033 ms
Total hot run time: 60979 ms

@doris-robot
Copy link

doris-robot commented Dec 8, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.84 seconds
stream load tsv: 589 seconds loaded 74807831229 Bytes, about 121 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17214740124 Bytes

yiguolei
yiguolei approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

PR approved by anyone and no changes requested.

HappenLee
HappenLee approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 0931eb5 into apache:master Dec 8, 2023
@zhiqiang-hhhh zhiqiang-hhhh deleted the revert-26403-add_catalog_for_audit branch December 8, 2023 14:12
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@zhiqiang-hhhh
Revert "[Improvement](auditlog) add column catalog for audit log and …
adb1218 
…audit log table (apache#26403)" (apache#28177)

This reverts commit daea751.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhiqiang-hhhh @doris-robot @yiguolei @HappenLee