Skip to content

Conversation

@zclllyybb
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

which marked static_cast<void> in https://github.com/apache/doris/pull/23395/files
partially fixed #28160

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit 4c0554f3ea571c2c5db211b9ffd97f3e16e08aa7, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4701	4465	4468	4465
q2	365	155	154	154
q3	1455	1269	1191	1191
q4	1091	913	896	896
q5	3115	3155	3115	3115
q6	252	130	126	126
q7	1002	485	476	476
q8	2202	2218	2157	2157
q9	6683	6637	6633	6633
q10	3213	3269	3255	3255
q11	329	202	201	201
q12	349	200	205	200
q13	4542	3809	3783	3783
q14	244	212	222	212
q15	564	516	524	516
q16	438	379	385	379
q17	998	573	550	550
q18	7577	7903	7148	7148
q19	1502	1332	1454	1332
q20	1610	411	340	340
q21	3046	2739	2636	2636
q22	350	272	280	272
Total cold run time: 45628 ms
Total hot run time: 40037 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4462	4391	4377	4377
q2	267	163	175	163
q3	3544	3549	3525	3525
q4	2392	2376	2367	2367
q5	5760	5770	5736	5736
q6	237	120	119	119
q7	2392	1859	1883	1859
q8	3522	3530	3508	3508
q9	9022	9000	9053	9000
q10	3910	3973	3990	3973
q11	502	359	388	359
q12	771	601	611	601
q13	4306	3569	3578	3569
q14	278	253	254	253
q15	566	525	511	511
q16	500	452	459	452
q17	1886	1862	1835	1835
q18	8719	8317	8171	8171
q19	1714	1729	1732	1729
q20	2243	1940	1947	1940
q21	6548	6177	6145	6145
q22	495	416	412	412
Total cold run time: 64036 ms
Total hot run time: 60604 ms

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.08 seconds
stream load tsv: 580 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.9 seconds inserted 10000000 Rows, about 334K ops/s
storage size: 17224431351 Bytes

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit 813bdad192c48dabe58ae148440bba73bcb9b897, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4645	4494	4477	4477
q2	364	141	138	138
q3	1474	1234	1236	1234
q4	1111	906	870	870
q5	3134	3122	3138	3122
q6	250	129	127	127
q7	996	487	477	477
q8	2191	2226	2189	2189
q9	6716	6697	6709	6697
q10	3208	3263	3264	3263
q11	333	204	207	204
q12	350	208	206	206
q13	4592	3819	3780	3780
q14	243	211	212	211
q15	569	514	526	514
q16	436	388	388	388
q17	1003	556	563	556
q18	7623	7761	7457	7457
q19	1517	1356	1425	1356
q20	622	293	302	293
q21	3017	2639	2673	2639
q22	351	279	291	279
Total cold run time: 44745 ms
Total hot run time: 40477 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4400	4394	4363	4363
q2	273	162	171	162
q3	3540	3539	3524	3524
q4	2376	2383	2372	2372
q5	5730	5752	5746	5746
q6	240	119	121	119
q7	2378	1903	1867	1867
q8	3513	3512	3510	3510
q9	9098	9047	9003	9003
q10	3889	3968	3960	3960
q11	504	397	384	384
q12	762	603	595	595
q13	4268	3529	3576	3529
q14	275	256	256	256
q15	574	512	516	512
q16	506	442	495	442
q17	1837	1844	1831	1831
q18	8805	8214	8667	8214
q19	1706	1767	1751	1751
q20	2250	1933	1922	1922
q21	6522	6183	6171	6171
q22	499	416	405	405
Total cold run time: 63945 ms
Total hot run time: 60638 ms

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.89 seconds
stream load tsv: 574 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17222955317 Bytes

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 11, 2023
@zhangstar333 zhangstar333 merged commit e158753 into apache:master Dec 11, 2023
@zclllyybb zclllyybb deleted the status_function branch December 11, 2023 03:05
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] fix potential bugs relating to discarded

4 participants