Skip to content

[fix](Nereids) multi_distinct_sum should inherit NullableAggregateFunction#28349

Merged
morrySnow merged 1 commit intoapache:masterfrom
morrySnow:fix_multi_distinct_nullable
Dec 14, 2023
Merged

[fix](Nereids) multi_distinct_sum should inherit NullableAggregateFunction#28349
morrySnow merged 1 commit intoapache:masterfrom
morrySnow:fix_multi_distinct_nullable

Conversation

@morrySnow
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
Tpch sf100 test result on commit 38f7672577a43a6cbfa5dd721e9bdc7503d33566, data reload: false

run tpch-sf100 query with default conf and session variables
q1	51688	31843	31801	31801
q2	381	142	139	139
q3	1563	1255	1233	1233
q4	1126	897	897	897
q5	3218	3197	3247	3197
q6	254	135	137	135
q7	1017	486	490	486
q8	2200	2233	2212	2212
q9	6953	6900	7078	6900
q10	3268	3281	3317	3281
q11	346	220	221	220
q12	351	208	213	208
q13	4550	4429	3818	3818
q14	437	319	330	319
q15	777	1291	1331	1291
q16	443	389	385	385
q17	1034	577	563	563
q18	7479	7349	7348	7348
q19	1524	1333	1440	1333
q20	562	322	298	298
q21	3073	2622	2671	2622
q22	350	277	290	277
Total cold run time: 92594 ms
Total hot run time: 68963 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	30788	31859	31805	31805
q2	284	168	172	168
q3	3689	3635	3620	3620
q4	2394	2371	2374	2371
q5	5800	5809	5796	5796
q6	245	135	133	133
q7	3079	3393	3365	3365
q8	3540	3547	3546	3546
q9	9186	9206	9227	9206
q10	3998	4061	4080	4061
q11	813	922	1356	922
q12	763	596	592	592
q13	4282	3579	3540	3540
q14	474	457	439	439
q15	1123	1331	1325	1325
q16	498	473	470	470
q17	1887	1851	1856	1851
q18	8918	9140	8246	8246
q19	1851	1775	1769	1769
q20	2881	2606	2572	2572
q21	6544	6325	6335	6325
q22	496	422	437	422
Total cold run time: 93533 ms
Total hot run time: 92544 ms

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.07 seconds
stream load tsv: 591 seconds loaded 74807831229 Bytes, about 120 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17224566744 Bytes

@morrySnow
Copy link
Contributor Author

run p0

@morrySnow
Copy link
Contributor Author

run pipelinex_p0

@morrySnow
Copy link
Contributor Author

run p0

@morrySnow
Copy link
Contributor Author

run pipelinex_p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 14, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit a540b7e into apache:master Dec 14, 2023
@morrySnow morrySnow deleted the fix_multi_distinct_nullable branch December 15, 2023 07:05
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Dec 15, 2023
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.4-merged p0_w reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants