Skip to content

[fix](FixedString) fix type char error when be config::enable_low_cardinality_optimize = false#28376

Merged
yiguolei merged 1 commit intoapache:branch-2.0from
Mryange:branch-2.0-fix-rf
Dec 15, 2023
Merged

[fix](FixedString) fix type char error when be config::enable_low_cardinality_optimize = false#28376
yiguolei merged 1 commit intoapache:branch-2.0from
Mryange:branch-2.0-fix-rf

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Dec 14, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Mryange
Copy link
Contributor Author

Mryange commented Dec 14, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.84% (7993/21123)
Line Coverage: 29.52% (64857/219671)
Region Coverage: 28.99% (33367/115092)
Branch Coverage: 24.89% (17129/68830)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fce93f22507a474996dcde9b660eb11fbb6fc869_fce93f22507a474996dcde9b660eb11fbb6fc869/report/index.html

@Mryange
Copy link
Contributor Author

Mryange commented Dec 14, 2023

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.82% (7990/21124)
Line Coverage: 29.50% (64830/219735)
Region Coverage: 28.97% (33353/115121)
Branch Coverage: 24.87% (17124/68850)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fce93f22507a474996dcde9b660eb11fbb6fc869_fce93f22507a474996dcde9b660eb11fbb6fc869/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 14, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 0b18ce0 into apache:branch-2.0 Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.4-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants