[fix](Nereids): TransposeSemiJoinAgg can't apply in Scalar Agg#28434
Merged
jackwener merged 1 commit intoapache:masterfrom Dec 15, 2023
Merged
[fix](Nereids): TransposeSemiJoinAgg can't apply in Scalar Agg#28434jackwener merged 1 commit intoapache:masterfrom
jackwener merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
run buildall |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
keanji-x
approved these changes
Dec 15, 2023
Contributor
|
PR approved by anyone and no changes requested. |
morrySnow
approved these changes
Dec 15, 2023
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
xiaokang
pushed a commit
that referenced
this pull request
Dec 17, 2023
* [fix](Planner): parse more Punctuation Date/DateTime (#28432) parse more Punctuation as separator, like `2021@01@01 00/00/00`; (cherry picked from commit 8986bb6) * [fix](Nereids): TransposeSemiJoinAgg can't apply in Scalar Agg (#28434) Scalar Agg shouldn't be pushdown, it will cause wrong result (cherry picked from commit 0f93ee8)
hello-stephen
pushed a commit
to hello-stephen/doris
that referenced
this pull request
Dec 28, 2023
…e#28434) Scalar Agg shouldn't be pushdown, it will cause wrong result
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Jan 12, 2024
…e#28434) Scalar Agg shouldn't be pushdown, it will cause wrong result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Scalar Agg shouldn't be pushdown, it will cause wrong result
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...