Skip to content

[enchancement](delete) fix delete stmt return error with fold on be #28557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HappenLee merged 2 commits into from
Jan 5, 2024
Merged

[enchancement](delete) fix delete stmt return error with fold on be #28557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
421f53a
[enchancement](delete) fix delete stmt return error with fold on be
zhangstar333 Dec 18, 2023
dcb088f
update
zhangstar333 Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/analysis/DeleteStmt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,12 @@ void analyzePredicate(Expr predicate, Analyzer analyzer) throws AnalysisExceptio
binaryPredicate.setChild(1, binaryPredicate.getChild(1).castTo(binaryPredicate.getChild(0).getType()));
binaryPredicate.analyze(analyzer);

ExprRewriter exprRewriter = new ExprRewriter(FoldConstantsRule.INSTANCE);
binaryPredicate.setChild(1, exprRewriter.rewrite(binaryPredicate.getChild(1), analyzer, null));
Expr rightChild = binaryPredicate.getChild(1);
Expr rewrittenExpr = FoldConstantsRule.INSTANCE.apply(rightChild, analyzer, null);
if (rightChild != rewrittenExpr) {
binaryPredicate.setChild(1, rewrittenExpr);
}

Expr leftExpr = binaryPredicate.getChild(0);
if (!(leftExpr instanceof SlotRef)) {
throw new AnalysisException(
Expand Down
17 changes: 17 additions & 0 deletions regression-test/suites/delete_p0/test_delete.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,4 +407,21 @@ suite("test_delete") {
qt_check_data7 """ select * from every_type_table order by col_1; """
sql "drop table every_type_table"


sql "drop table if exists test2"
sql """
CREATE TABLE `test2`
(
col_1 int,
col_2 decimalv2(10,3)
)ENGINE=OLAP
duplicate KEY(`col_1`)
COMMENT 'OLAP'
DISTRIBUTED BY HASH(`col_1`) BUCKETS 1
PROPERTIES (
"replication_allocation" = "tag.location.default: 1"
);
"""
sql "set enable_fold_constant_by_be = true;"
sql "DELETE FROM test2 WHERE col_2 = cast(123.45 as decimalv2(10,3));"
}