Skip to content

[chore](error msg) print type info when colocate with ddl failed due type mismatch #28905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Dec 23, 2023
Merged

[chore](error msg) print type info when colocate with ddl failed due type mismatch #28905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/catalog/ColocateGroupSchema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,11 @@ public void checkDistribution(DistributionInfo distributionInfo) throws DdlExcep
continue;
}
if (!targetColType.equals(info.getDistributionColumns().get(i).getType())) {
String typeName = info.getDistributionColumns().get(i).getType().toString();
String colName = info.getDistributionColumns().get(i).getName();
String formattedString = colName + "(" + typeName + ")";
ErrorReport.reportDdlException(ErrorCode.ERR_COLOCATE_TABLE_MUST_HAS_SAME_DISTRIBUTION_COLUMN_TYPE,
info.getDistributionColumns().get(i).getName(), targetColType);
formattedString, targetColType);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion fe/fe-core/src/test/java/org/apache/doris/catalog/ColocateTableTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ public void testDistributionColumnsType() throws Exception {
+ ");");

expectedEx.expect(DdlException.class);
expectedEx.expectMessage("Colocate tables distribution columns must have the same data type: k2 should be INT");
expectedEx.expectMessage("Colocate tables distribution columns must have the same data type: k2(VARCHAR(10)) should be INT");
createTable("create table " + dbName + "." + tableName2 + " (\n"
+ " `k1` int NULL COMMENT \"\",\n"
+ " `k2` varchar(10) NULL COMMENT \"\"\n"
Expand Down