Skip to content

[opt](Nereids) remove decimalv2 signature from min, max, sum, nvl and case when#29282

Merged
yiguolei merged 1 commit intoapache:masterfrom
morrySnow:fix_minmax_ifnull_caswhen
Dec 29, 2023
Merged

[opt](Nereids) remove decimalv2 signature from min, max, sum, nvl and case when#29282
yiguolei merged 1 commit intoapache:masterfrom
morrySnow:fix_minmax_ifnull_caswhen

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Dec 29, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow
Copy link
Contributor Author

morrySnow commented Dec 29, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Dec 29, 2023

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools

Tpch sf100 test result on commit 2bcd137f0642b228f464cca39cdf4a0bc244a3d4, data reload: false

------ Round 1 ----------------------------------
q1	17633	5430	5137	5137
q2	2040	167	153	153
q3	10596	1166	1179	1166
q4	10243	831	841	831
q5	7830	2996	2931	2931
q6	212	134	136	134
q7	934	525	549	525
q8	9320	2094	2052	2052
q9	6915	6451	6386	6386
q10	8308	3111	3047	3047
q11	424	237	238	237
q12	398	242	244	242
q13	17984	3657	3641	3641
q14	249	215	216	215
q15	610	565	563	563
q16	453	405	403	403
q17	981	478	475	475
q18	7681	6932	6921	6921
q19	1594	1354	1374	1354
q20	714	337	335	335
q21	2816	2396	2500	2396
q22	388	323	336	323
Total cold run time: 108323 ms
Total hot run time: 39467 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5180	5185	5073	5073
q2	341	253	270	253
q3	3373	3316	3274	3274
q4	2149	2056	2081	2056
q5	6117	6043	5983	5983
q6	222	130	131	130
q7	2366	1895	1944	1895
q8	3403	3470	3500	3470
q9	8935	8872	8881	8872
q10	3858	3913	3890	3890
q11	604	478	494	478
q12	792	675	683	675
q13	7195	3200	3228	3200
q14	297	272	277	272
q15	620	563	551	551
q16	580	516	501	501
q17	1984	1806	1748	1748
q18	8992	8609	8579	8579
q19	1638	1607	1585	1585
q20	2240	1992	1982	1982
q21	5637	5283	5303	5283
q22	543	464	497	464
Total cold run time: 67066 ms
Total hot run time: 60214 ms

@doris-robot
Copy link

doris-robot commented Dec 29, 2023

TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools

TPC-DS sf100 test result on commit 2bcd137f0642b228f464cca39cdf4a0bc244a3d4, data reload: false

run tpcds-sf100 query with default conf and session variables
query1	921	355	349	349
query2	6466	1935	1944	1935
query3	6641	231	215	215
query4	28311	22722	22480	22480
query5	4986	606	549	549
query6	292	192	188	188
query7	4598	295	276	276
query8	248	202	197	197
query9	8040	2665	2655	2655
query10	451	253	245	245
query11	16247	15457	15588	15457
query12	148	86	78	78
query13	1668	336	334	334
query14	12328	7327	7267	7267
query15	246	195	205	195
query16	6498	292	285	285
query17	1791	509	521	509
query18	1913	264	267	264
query19	269	141	143	141
query20	86	80	80	80
query21	190	98	97	97
query22	5050	4750	4777	4750
query23	31939	31455	31466	31455
query24	10946	2835	2839	2835
query25	581	362	358	358
query26	1489	147	152	147
query27	2869	285	285	285
query28	7136	2013	2011	2011
query29	1454	406	411	406
query30	282	140	148	140
query31	955	779	787	779
query32	88	68	65	65
query33	727	285	278	278
query34	848	447	442	442
query35	867	759	782	759
query36	1308	1221	1319	1221
query37	107	89	82	82
query38	3320	3306	3217	3217
query39	1310	1302	1275	1275
query40	195	97	91	91
query41	40	35	34	34
query42	106	94	96	94
query43	547	507	512	507
query44	1082	768	780	768
query45	200	192	185	185
query46	1104	679	668	668
query47	1744	1635	1571	1571
query48	332	268	260	260
query49	1089	337	335	335
query50	750	378	381	378
query51	5350	5388	5317	5317
query52	104	97	94	94
query53	217	157	155	155
query54	1356	610	598	598
query55	109	84	88	84
query56	227	208	204	204
query57	1036	923	932	923
query58	232	207	209	207
query59	2891	2660	2709	2660
query60	268	239	241	239
query61	90	91	87	87
query62	646	468	481	468
query63	176	155	157	155
query64	5019	1775	1719	1719
query65	3359	3246	3289	3246
query66	1162	345	343	343
query67	15611	15261	15626	15261
query68	10662	538	557	538
query69	558	263	257	257
query70	1592	1459	1584	1459
query71	577	233	235	233
query72	5318	3537	3589	3537
query73	1121	326	321	321
query74	6921	6416	6386	6386
query75	5025	2281	2335	2281
query76	4548	1122	1113	1113
query77	873	290	273	273
query78	9116	8591	8659	8591
query79	5595	526	522	522
query80	2794	384	375	375
query81	513	233	220	220
query82	324	124	115	115
query83	313	143	141	141
query84	258	55	54	54
query85	1788	321	279	279
query86	419	371	423	371
query87	3526	3368	3362	3362
query88	3078	2414	2408	2408
query89	344	279	279	279
query90	1941	234	237	234
query91	116	88	102	88
query92	76	54	55	54
query93	2496	461	499	461
query94	812	215	216	215
query95	524	482	462	462
query96	649	329	335	329
query97	4272	4159	4189	4159
query98	209	193	190	190
query99	1169	867	896	867
Total cold run time: 296183 ms
Total hot run time: 181126 ms

yiguolei
yiguolei approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2023

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 989d20e into apache:master Dec 29, 2023
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 12, 2024
@morrySnow @HappenLee
[opt](Nereids) remove decimalv2 signature from min, max, sum, nvl and…
a11a489 
… case when (apache#29282)
@morrySnow morrySnow deleted the fix_minmax_ifnull_caswhen branch February 27, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morrySnow @doris-robot @yiguolei @starocean999