Skip to content

[fix](memory) Fix mem tracker web page notice #29361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Jan 3, 2024
Merged

[fix](memory) Fix mem tracker web page notice #29361

yiguolei merged 1 commit into from
Jan 3, 2024

Conversation

@xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Jan 1, 2024

Proposed changes

Fix mem tracker web page notice, see documentation for details.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Jan 1, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jan 1, 2024

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools

Tpch sf100 test result on commit 64aeb05c611db2e355fe5413ca5d6107859c1713, data reload: false

------ Round 1 ----------------------------------
q1	17626	5118	5094	5094
q2	2015	158	148	148
q3	10530	1078	1167	1078
q4	10189	795	813	795
q5	7801	2943	2921	2921
q6	214	139	138	138
q7	952	554	492	492
q8	9287	2015	2038	2015
q9	6911	6408	6338	6338
q10	8275	3032	3019	3019
q11	430	217	221	217
q12	405	244	239	239
q13	18003	3617	3625	3617
q14	248	217	206	206
q15	573	553	537	537
q16	461	386	398	386
q17	957	479	490	479
q18	7286	6610	6634	6610
q19	1577	1416	1354	1354
q20	747	353	382	353
q21	2832	2414	2419	2414
q22	381	340	336	336
Total cold run time: 107700 ms
Total hot run time: 38786 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5161	5100	5103	5100
q2	338	269	262	262
q3	3307	3243	3266	3243
q4	2112	2023	2025	2023
q5	5803	5785	5814	5785
q6	216	128	132	128
q7	2294	1910	1894	1894
q8	3393	3445	3481	3445
q9	8875	8775	8730	8730
q10	3779	3863	3815	3815
q11	598	502	477	477
q12	814	635	665	635
q13	8872	3212	3214	3212
q14	285	259	267	259
q15	593	538	530	530
q16	571	503	527	503
q17	1957	1776	1763	1763
q18	8615	8384	8322	8322
q19	1621	1602	1578	1578
q20	2184	1962	1971	1962
q21	5556	5305	5289	5289
q22	547	498	504	498
Total cold run time: 67491 ms
Total hot run time: 59453 ms

@doris-robot
Copy link

doris-robot commented Jan 1, 2024

TeamCity be ut coverage result:
Function Coverage: 36.62% (8614/23520)
Line Coverage: 28.68% (70013/244080)
Region Coverage: 27.67% (36241/130954)
Branch Coverage: 24.38% (18518/75968)
Coverage Report: http://coverage.selectdb-in.cc/coverage/64aeb05c611db2e355fe5413ca5d6107859c1713_64aeb05c611db2e355fe5413ca5d6107859c1713/report/index.html

@doris-robot
Copy link

doris-robot commented Jan 1, 2024

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools

Tpch sf100 test result on commit 64aeb05c611db2e355fe5413ca5d6107859c1713, data reload: false

run tpch-sf100 query with default conf and session variables
q1	5476	5158	5188	5158
q2	383	171	177	171
q3	1463	1141	1102	1102
q4	1079	859	878	859
q5	3081	3141	2976	2976
q6	224	136	132	132
q7	964	540	523	523
q8	2163	2182	2197	2182
q9	6709	6711	6661	6661
q10	3201	3238	3107	3107
q11	360	229	218	218
q12	380	242	237	237
q13	4408	3665	3627	3627
q14	249	219	220	219
q15	604	560	557	557
q16	461	436	401	401
q17	1042	569	621	569
q18	7053	6841	6786	6786
q19	1674	1567	1464	1464
q20	591	353	370	353
q21	2899	2395	2550	2395
q22	404	312	319	312
Total cold run time: 44868 ms
Total hot run time: 40009 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	5109	5118	5087	5087
q2	341	262	256	256
q3	3386	3337	3324	3324
q4	2120	2031	2006	2006
q5	5974	5914	5919	5914
q6	222	122	128	122
q7	2392	1907	1905	1905
q8	3539	3663	3684	3663
q9	9042	8978	8943	8943
q10	3885	3921	3900	3900
q11	591	491	475	475
q12	817	684	672	672
q13	3876	3206	3209	3206
q14	313	270	268	268
q15	627	540	553	540
q16	552	533	498	498
q17	2033	1793	1821	1793
q18	8752	8254	8391	8254
q19	1749	1681	1685	1681
q20	2283	1985	2002	1985
q21	5687	5321	5313	5313
q22	575	520	488	488
Total cold run time: 63865 ms
Total hot run time: 60293 ms

@doris-robot
Copy link

doris-robot commented Jan 1, 2024

TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools

TPC-DS sf100 test result on commit 64aeb05c611db2e355fe5413ca5d6107859c1713, data reload: false

run tpcds-sf100 query with default conf and session variables
query1	909	355	346	346
query2	6438	1948	1873	1873
query3	6646	210	202	202
query4	26705	22451	22418	22418
query5	5772	510	565	510
query6	270	185	180	180
query7	4574	277	277	277
query8	229	211	200	200
query9	8194	2539	2627	2539
query10	419	245	258	245
query11	16122	15484	15501	15484
query12	138	79	78	78
query13	1626	336	318	318
query14	11605	6989	7108	6989
query15	259	184	191	184
query16	6391	282	276	276
query17	1818	498	496	496
query18	1924	268	267	267
query19	279	143	138	138
query20	83	79	79	79
query21	187	96	96	96
query22	4919	4836	4529	4529
query23	32116	31322	31163	31163
query24	12120	2825	2784	2784
query25	588	367	351	351
query26	1686	145	147	145
query27	2868	282	275	275
query28	7272	1960	1946	1946
query29	2040	394	391	391
query30	292	145	142	142
query31	951	773	759	759
query32	87	65	61	61
query33	723	286	275	275
query34	855	447	439	439
query35	897	759	789	759
query36	1289	1316	1225	1225
query37	180	78	78	78
query38	3390	3272	3290	3272
query39	1325	1280	1286	1280
query40	306	100	93	93
query41	38	34	34	34
query42	96	95	94	94
query43	548	513	509	509
query44	1079	712	731	712
query45	201	184	185	184
query46	1068	636	639	636
query47	1618	1682	1564	1564
query48	332	268	263	263
query49	1197	334	318	318
query50	753	329	358	329
query51	5388	5237	5300	5237
query52	102	84	98	84
query53	226	156	153	153
query54	1367	588	595	588
query55	95	87	86	86
query56	213	202	212	202
query57	1049	990	981	981
query58	218	209	208	208
query59	2878	2645	2626	2626
query60	268	236	238	236
query61	88	84	88	84
query62	627	450	455	450
query63	172	153	156	153
query64	5840	1719	1716	1716
query65	3358	3281	3257	3257
query66	1273	339	323	323
query67	15702	15143	15499	15143
query68	12609	521	529	521
query69	509	252	266	252
query70	1696	1514	1338	1338
query71	496	238	239	238
query72	5611	3617	3568	3568
query73	2902	310	313	310
query74	6994	6358	6389	6358
query75	5192	2242	2250	2242
query76	6297	1162	1139	1139
query77	659	284	304	284
query78	9049	8701	8723	8701
query79	1048	508	509	508
query80	564	379	368	368
query81	449	207	216	207
query82	208	104	107	104
query83	188	135	133	133
query84	246	53	52	52
query85	974	311	277	277
query86	384	381	367	367
query87	3588	3334	3331	3331
query88	3042	2247	2269	2247
query89	341	262	281	262
query90	1894	193	208	193
query91	124	90	94	90
query92	63	56	54	54
query93	1277	507	434	434
query94	883	189	188	188
query95	464	428	427	427
query96	623	316	315	315
query97	4290	4157	4180	4157
query98	222	201	195	195
query99	1155	871	863	863
Total cold run time: 294327 ms
Total hot run time: 179055 ms

@doris-robot
Copy link

doris-robot commented Jan 1, 2024

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47 seconds
stream load tsv: 576 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.0 seconds inserted 10000000 Rows, about 357K ops/s
storage size: 17183989915 Bytes

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024

PR approved by anyone and no changes requested.

wangbo
wangbo approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit be1d9c3 into apache:master Jan 3, 2024
seawinde pushed a commit to seawinde/doris that referenced this pull request Jan 3, 2024
@xinyiZzz @seawinde
[fix](memory) Fix mem tracker web page notice apache#29361
7fdaed3
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 12, 2024
@xinyiZzz @HappenLee
[fix](memory) Fix mem tracker web page notice apache#29361
4364aec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@wangbo wangbo wangbo approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xinyiZzz @doris-robot @yiguolei @wangbo