Skip to content

Conversation

@zclllyybb
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

mysql> select str_to_date('2023','%Y');
+---------------------------+
| str_to_date('2023', '%Y') |
+---------------------------+
| 2023-01-01                |
+---------------------------+

mysql> select STR_TO_DATE('2023-12', '%Y-%m');
+---------------------------------+
| str_to_date('2023-12', '%Y-%m') |
+---------------------------------+
| 2023-12-01                      |
+---------------------------------+

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38489 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 27be501bb03c86578eb34228c0bc0ef88c0d50f3, data reload: false

------ Round 1 ----------------------------------
q1	17961	5031	4899	4899
q2	2049	145	131	131
q3	10691	1097	1172	1097
q4	10248	806	781	781
q5	7839	3184	3131	3131
q6	205	123	128	123
q7	856	499	485	485
q8	9288	1959	1976	1959
q9	6517	6459	6447	6447
q10	8234	3078	3070	3070
q11	415	206	215	206
q12	363	192	195	192
q13	18119	3418	3404	3404
q14	235	210	211	210
q15	556	528	514	514
q16	436	384	379	379
q17	935	479	490	479
q18	7405	6690	6637	6637
q19	1577	1376	1413	1376
q20	567	293	309	293
q21	2764	2363	2421	2363
q22	368	329	313	313
Total cold run time: 107628 ms
Total hot run time: 38489 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4987	5033	4919	4919
q2	311	201	205	201
q3	3335	3301	3301	3301
q4	2228	2236	2236	2236
q5	5827	5771	5789	5771
q6	192	116	117	116
q7	2300	1844	1849	1844
q8	3424	3531	3584	3531
q9	8867	8857	8839	8839
q10	3732	3787	3842	3787
q11	552	417	410	410
q12	784	599	590	590
q13	6172	3224	3209	3209
q14	292	272	260	260
q15	573	514	514	514
q16	517	454	445	445
q17	2034	2045	2021	2021
q18	8754	8374	8285	8285
q19	1605	1622	1619	1619
q20	2167	1945	1925	1925
q21	5960	5747	5672	5672
q22	575	502	494	494
Total cold run time: 65188 ms
Total hot run time: 59989 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.68% (8649/23580)
Line Coverage: 28.73% (70472/245305)
Region Coverage: 27.66% (36413/131640)
Branch Coverage: 24.36% (18630/76466)
Coverage Report: http://coverage.selectdb-in.cc/coverage/27be501bb03c86578eb34228c0bc0ef88c0d50f3_27be501bb03c86578eb34228c0bc0ef88c0d50f3/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 178906 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 27be501bb03c86578eb34228c0bc0ef88c0d50f3, data reload: false

query1	929	337	328	328
query2	6719	1868	1945	1868
query3	6696	210	206	206
query4	25990	22084	22245	22084
query5	5818	502	499	499
query6	284	183	202	183
query7	4636	270	270	270
query8	254	218	213	213
query9	9161	2759	2927	2759
query10	453	240	250	240
query11	16190	15227	15319	15227
query12	130	83	76	76
query13	1625	341	351	341
query14	12067	7340	7468	7340
query15	254	190	192	190
query16	6486	293	277	277
query17	1878	495	483	483
query18	1961	265	282	265
query19	293	143	137	137
query20	85	78	79	78
query21	184	92	91	91
query22	5083	4844	4886	4844
query23	32087	31210	31433	31210
query24	11186	2850	2825	2825
query25	565	342	346	342
query26	1622	160	156	156
query27	2876	282	275	275
query28	7112	1934	1919	1919
query29	1626	406	380	380
query30	278	148	145	145
query31	1012	775	779	775
query32	92	65	58	58
query33	736	275	281	275
query34	876	443	443	443
query35	849	757	760	757
query36	1268	1188	1254	1188
query37	103	74	71	71
query38	3408	3286	3301	3286
query39	1323	1296	1295	1295
query40	299	103	91	91
query41	41	36	35	35
query42	104	91	99	91
query43	542	518	498	498
query44	1065	718	717	717
query45	207	193	188	188
query46	1060	672	685	672
query47	1727	1578	1522	1522
query48	403	316	307	307
query49	1238	328	325	325
query50	738	324	330	324
query51	5307	5237	5329	5237
query52	103	85	94	85
query53	219	156	155	155
query54	1419	581	582	581
query55	98	92	86	86
query56	215	196	203	196
query57	1032	945	982	945
query58	240	212	218	212
query59	2754	2591	2545	2545
query60	255	231	243	231
query61	83	80	81	80
query62	675	474	498	474
query63	166	153	156	153
query64	5837	1675	1693	1675
query65	3357	3278	3273	3273
query66	1144	349	345	345
query67	15527	15209	15807	15209
query68	9882	508	513	508
query69	582	283	283	283
query70	1717	1538	1577	1538
query71	478	229	226	226
query72	4532	2843	2866	2843
query73	1874	312	316	312
query74	6984	6414	6452	6414
query75	4638	2326	2294	2294
query76	6280	1115	1047	1047
query77	676	287	272	272
query78	9651	8704	8743	8704
query79	1029	500	510	500
query80	566	353	352	352
query81	471	208	212	208
query82	236	88	95	88
query83	162	142	136	136
query84	267	56	61	56
query85	960	288	288	288
query86	386	383	371	371
query87	3536	3439	3403	3403
query88	2894	2217	2214	2214
query89	335	276	272	272
query90	1824	195	206	195
query91	172	128	131	128
query92	69	58	52	52
query93	1076	421	482	421
query94	774	192	196	192
query95	473	442	422	422
query96	630	320	312	312
query97	4349	4167	4208	4167
query98	213	200	191	191
query99	1134	867	846	846
Total cold run time: 288900 ms
Total hot run time: 178906 ms

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.24 seconds
stream load tsv: 563 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 21.5 seconds inserted 10000000 Rows, about 465K ops/s
storage size: 17183908069 Bytes

@doris-robot
Copy link

ClickBench: Total hot run time: 31.14 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 27be501bb03c86578eb34228c0bc0ef88c0d50f3, data reload: false

query1	0.07	0.05	0.06
query2	0.06	0.02	0.02
query3	0.25	0.13	0.12
query4	1.75	0.13	0.14
query5	0.52	0.52	0.52
query6	1.35	0.63	0.64
query7	0.02	0.01	0.01
query8	0.05	0.03	0.03
query9	0.55	0.53	0.48
query10	0.54	0.54	0.55
query11	0.12	0.09	0.08
query12	0.12	0.09	0.08
query13	0.60	0.59	0.61
query14	0.79	0.78	0.79
query15	0.82	0.80	0.79
query16	0.35	0.35	0.35
query17	0.98	0.96	0.95
query18	0.25	0.26	0.25
query19	1.84	1.70	1.76
query20	0.01	0.01	0.01
query21	15.42	0.57	0.57
query22	2.70	2.89	2.13
query23	17.28	0.77	0.90
query24	2.50	5.84	1.14
query25	1.86	0.15	0.16
query26	0.13	0.13	0.14
query27	0.15	0.15	0.15
query28	8.64	0.83	0.81
query29	12.55	3.28	3.09
query30	0.56	0.50	0.47
query31	2.79	0.36	0.37
query32	3.33	0.48	0.50
query33	3.20	3.20	3.24
query34	15.75	4.14	4.18
query35	4.17	4.14	4.15
query36	1.10	1.07	1.04
query37	0.07	0.05	0.05
query38	0.04	0.03	0.03
query39	0.03	0.01	0.01
query40	0.16	0.13	0.13
query41	0.07	0.01	0.02
query42	0.02	0.02	0.01
query43	0.02	0.02	0.02
Total cold run time: 103.58 s
Total hot run time: 31.14 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 27be501bb03c86578eb34228c0bc0ef88c0d50f3 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      33 seconds loaded 861443392 Bytes, about 24 MB/s
Insert into select:       14.3 seconds inserted 10000000 Rows, about 699K ops/s

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 11, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.5-merged dev/3.0.0-merged reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants