-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[opt](parquet-reader) Opt parquet fixed length decimal type reading. #29825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](parquet-reader) Opt parquet fixed length decimal type reading. #29825
Conversation
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38478 ms |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-DS: Total hot run time: 178366 ms |
ClickBench: Total hot run time: 30.62 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
c39293f to
de509f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
| // under the License. | ||
|
|
||
| #pragma once | ||
| #include <gen_cpp/PlanNodes_types.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: 'gen_cpp/PlanNodes_types.h' file not found [clang-diagnostic-error]
#include <gen_cpp/PlanNodes_types.h>
^|
run buildall |
TPC-H: Total hot run time: 38400 ms |
TPC-DS: Total hot run time: 178587 ms |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
ClickBench: Total hot run time: 30.08 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
de509f0 to
9d739bc
Compare
|
run buildall |
TPC-H: Total hot run time: 38459 ms |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-DS: Total hot run time: 178151 ms |
ClickBench: Total hot run time: 30.75 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Proposed changes
[opt] (parquet-reader) Opt parquet fixed length decimal type reading.
For tpch-500-parquet(one node): 5.81 s -> 2.70 s
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...