Skip to content

[pipelineX](fix) Fix runtime filter dependency DCHECK failed#30038

Merged
Gabriel39 merged 1 commit intoapache:masterfrom
Gabriel39:fix_0117
Jan 17, 2024
Merged

[pipelineX](fix) Fix runtime filter dependency DCHECK failed#30038
Gabriel39 merged 1 commit intoapache:masterfrom
Gabriel39:fix_0117

Conversation

@Gabriel39
Copy link
Contributor

@Gabriel39 Gabriel39 commented Jan 17, 2024

Proposed changes

F20240116 16:59:52.623409 776139 pipeline_x_task.cpp:207] Check failed: false QueryId: 7b0ba0fbdc9c4cb6-9c163ded1e6df216
InstanceId: 7b0ba0fbdc9c4cb6-9c163ded1e6df233
PipelineTask[this = 0x7facd2b2a700, state = RUNNABLE, data state = 0, dry run = false, elapse time = 10133863ns], block dependency = NULL, is running = true
operators:
OLAP_SCAN_OPERATOR: id=2, parallel_tasks=8
LOCAL_EXCHANGE_SINK_OPERATOR (PASSTHROUGH): id=-6
Read Dependency Information:
0. ScanDependency: id=2, block task = 0, ready=false, _scanner_done = false
Write Dependency Information:

  1. LocalExchangeSinkDependency: id=-6, block task = 0, ready=true
    Runtime Filter Dependency Information:
  2. OLAP_SCAN_OPERATOR_FILTER_DEPENDENCY: id=2, block task = 0, ready=false, _filters = 1, _blocked_by_rf = true
    Finish Dependency Information:
    *** Check failure stack trace: ***
    @ 0x5588d0de0d66 google::LogMessage::SendToLog()
    @ 0x5588d0ddd7b0 google::LogMessage::Flush()
    @ 0x5588d0de15a9 google::LogMessageFatal::~LogMessageFatal()
    @ 0x5588d0db2024 doris::pipeline::PipelineXTask::_open()
    @ 0x5588d0db228b doris::pipeline::PipelineXTask::execute()
    @ 0x5588d0dbc949 doris::pipeline::TaskScheduler::_do_work()
    @ 0x5588c8231648 doris::ThreadPool::dispatch_thread()
    @ 0x5588c8226ce1 doris::Thread::supervise_thread()
    @ 0x7fb670c93609 start_thread
    @ 0x7fb670f40133 clone
    @ (nil) (unknown)
    *** Query id: 7b0ba0fbdc9c4cb6-9c163ded1e6df216 ***
    *** tablet id: 0 ***
    *** Aborted at 1705395593 (unix time) try "date -d @1705395593" if you are using GNU date ***
    *** Current BE git commitID: 3f22c79 ***
    *** SIGABRT unknown detail explain (@0xbd692) received by PID 775826 (TID 776139 OR 0x7fb5d2ace700) from PID 775826; stack trace: ***
    0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /home/zcp/repo_center/doris_master/doris/be/src/common/signal_handler.h:417
    1# 0x00007FB670E64090 in /lib/x86_64-linux-gnu/libc.so.6
    2# raise at ../sysdeps/unix/sysv/linux/raise.c:51
    3# abort at /build/glibc-SzIz7B/glibc-2.31/stdlib/abort.c:81
    4# 0x00005588D0DEB57D in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
    5# 0x00005588D0DDDC7A in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
    6# google::LogMessage::SendToLog() in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
    7# google::LogMessage::Flush() in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
    8# google::LogMessageFatal::~LogMessageFatal() in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
    9# doris::pipeline::PipelineXTask::_open() at /home/zcp/repo_center/doris_master/doris/be/src/pipeline/pipeline_x/pipeline_x_task.cpp:207
    10# doris::pipeline::PipelineXTask::execute(bool*) at /home/zcp/repo_center/doris_master/doris/be/src/pipeline/pipeline_x/pipeline_x_task.cpp:244
    11# doris::pipeline::TaskScheduler::_do_work(unsigned long) at /home/zcp/repo_center/doris_master/doris/be/src/pipeline/task_scheduler.cpp:286
    12# doris::ThreadPool::dispatch_thread() in /mnt/hdd01/ci/master-deploy/be/lib/doris_be
    13# doris::Thread::supervise_thread(void*) at /home/zcp/repo_center/doris_master/doris/be/src/util/thread.cpp:499
    14# start_thread at /build/glibc-SzIz7B/glibc-2.31/nptl/pthread_create.c:478

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Gabriel39
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.67% (8648/23584)
Line Coverage: 28.73% (70622/245811)
Region Coverage: 27.62% (36444/131932)
Branch Coverage: 24.34% (18641/76592)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c0b9e8dc12ed7628664f1d459bbf7d597ef889ab_c0b9e8dc12ed7628664f1d459bbf7d597ef889ab/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 38667 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c0b9e8dc12ed7628664f1d459bbf7d597ef889ab, data reload: false

------ Round 1 ----------------------------------
q1	17674	5187	5226	5187
q2	2044	139	134	134
q3	10639	1142	1153	1142
q4	10217	803	857	803
q5	7730	3136	3089	3089
q6	196	119	124	119
q7	847	491	483	483
q8	9219	1924	1930	1924
q9	7241	6336	6322	6322
q10	8200	3028	3017	3017
q11	406	213	206	206
q12	357	185	194	185
q13	17990	3366	3357	3357
q14	240	214	214	214
q15	540	509	493	493
q16	458	376	419	376
q17	928	505	519	505
q18	7515	6979	6784	6784
q19	1555	1340	1435	1340
q20	564	319	316	316
q21	2758	2385	2370	2370
q22	371	315	301	301
Total cold run time: 107689 ms
Total hot run time: 38667 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5484	5265	5334	5265
q2	324	215	215	215
q3	3267	3248	3197	3197
q4	2056	2184	2003	2003
q5	5934	5798	5952	5798
q6	195	115	116	115
q7	2304	1814	1944	1814
q8	3215	3349	3383	3349
q9	8846	8800	8769	8769
q10	3908	3758	3828	3758
q11	569	462	463	462
q12	798	599	601	599
q13	16913	3146	3144	3144
q14	284	249	279	249
q15	542	503	502	502
q16	525	483	487	483
q17	1871	1838	1814	1814
q18	9453	16589	9413	9413
q19	24924	1589	1518	1518
q20	4599	1925	1918	1918
q21	14426	5306	5419	5306
q22	979	531	556	531
Total cold run time: 111416 ms
Total hot run time: 60222 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 177171 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c0b9e8dc12ed7628664f1d459bbf7d597ef889ab, data reload: false

query1	932	332	324	324
query2	6553	1893	1775	1775
query3	6702	213	203	203
query4	31151	22167	22373	22167
query5	6908	530	595	530
query6	257	172	176	172
query7	4598	264	266	264
query8	218	178	180	178
query9	8434	2518	2509	2509
query10	431	220	235	220
query11	17041	15641	15462	15462
query12	123	71	69	69
query13	1680	381	375	375
query14	10547	6939	6862	6862
query15	205	182	185	182
query16	4604	232	229	229
query17	998	489	458	458
query18	1781	258	253	253
query19	186	142	133	133
query20	74	68	71	68
query21	190	124	131	124
query22	4951	4771	4741	4741
query23	31652	30836	30799	30799
query24	12499	2806	2816	2806
query25	561	309	308	308
query26	1787	142	146	142
query27	3223	268	275	268
query28	7178	1819	1807	1807
query29	2075	614	622	614
query30	281	141	140	140
query31	936	757	754	754
query32	80	51	49	49
query33	703	227	210	210
query34	1120	465	457	457
query35	866	777	734	734
query36	1389	1235	1217	1217
query37	88	59	58	58
query38	3355	3253	3264	3253
query39	1312	1247	1281	1247
query40	352	83	87	83
query41	38	35	34	34
query42	88	82	78	78
query43	547	511	505	505
query44	1043	691	697	691
query45	199	183	180	180
query46	1080	666	649	649
query47	1714	1630	1509	1509
query48	388	316	328	316
query49	1209	288	297	288
query50	689	316	306	306
query51	5273	5186	5157	5157
query52	86	83	72	72
query53	324	258	251	251
query54	885	429	439	429
query55	80	76	74	74
query56	177	169	163	163
query57	1016	955	965	955
query58	190	166	161	161
query59	3019	2760	2689	2689
query60	205	192	188	188
query61	85	80	90	80
query62	654	415	396	396
query63	277	257	258	257
query64	6158	1821	1780	1780
query65	3327	3251	3246	3246
query66	1400	319	311	311
query67	15681	15175	15122	15122
query68	15932	495	511	495
query69	608	298	294	294
query70	2372	1501	1544	1501
query71	545	215	211	211
query72	4897	2823	2818	2818
query73	4450	321	326	321
query74	7238	6473	6472	6472
query75	5319	2393	2345	2345
query76	6081	1057	1038	1038
query77	730	240	241	240
query78	8972	8888	8602	8602
query79	2644	497	499	497
query80	654	324	310	310
query81	448	207	208	207
query82	206	84	90	84
query83	281	117	119	117
query84	276	67	68	67
query85	1066	327	314	314
query86	387	422	413	413
query87	3479	3382	3306	3306
query88	3010	2267	2263	2263
query89	438	373	358	358
query90	2134	191	194	191
query91	165	125	130	125
query92	54	44	46	44
query93	1395	434	398	398
query94	1319	162	159	159
query95	503	467	446	446
query96	619	330	340	330
query97	4312	4211	4140	4140
query98	220	192	185	185
query99	1077	751	749	749
Total cold run time: 305684 ms
Total hot run time: 177171 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.89 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c0b9e8dc12ed7628664f1d459bbf7d597ef889ab, data reload: false

query1	0.03	0.03	0.02
query2	0.05	0.02	0.02
query3	0.23	0.05	0.05
query4	1.69	0.10	0.09
query5	0.55	0.53	0.53
query6	1.30	0.62	0.64
query7	0.02	0.01	0.01
query8	0.03	0.02	0.02
query9	0.53	0.50	0.49
query10	0.54	0.55	0.55
query11	0.12	0.09	0.09
query12	0.11	0.10	0.09
query13	0.59	0.60	0.60
query14	0.75	0.82	0.77
query15	0.80	0.77	0.77
query16	0.38	0.37	0.37
query17	1.04	0.99	1.04
query18	0.24	0.24	0.27
query19	1.87	1.77	1.74
query20	0.01	0.01	0.02
query21	15.40	0.56	0.57
query22	2.22	2.44	1.92
query23	17.33	0.83	0.75
query24	2.50	1.16	1.29
query25	0.46	0.17	0.16
query26	0.59	0.13	0.13
query27	0.06	0.06	0.05
query28	11.34	0.76	0.77
query29	12.51	3.14	3.19
query30	0.53	0.49	0.45
query31	2.79	0.33	0.34
query32	3.38	0.48	0.48
query33	3.29	3.26	3.22
query34	15.74	4.19	4.26
query35	4.27	4.19	4.19
query36	1.13	1.08	1.09
query37	0.06	0.05	0.05
query38	0.03	0.03	0.03
query39	0.02	0.01	0.01
query40	0.17	0.13	0.13
query41	0.07	0.01	0.02
query42	0.02	0.01	0.02
query43	0.03	0.01	0.02
Total cold run time: 104.82 s
Total hot run time: 30.89 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit c0b9e8dc12ed7628664f1d459bbf7d597ef889ab with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       14.8 seconds inserted 10000000 Rows, about 675K ops/s

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 17, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.0-merged dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants