[fix](injection) don't disturb CLOSE_LOAD message in LoadStream#30097
Merged
dataroaring merged 1 commit intoapache:masterfrom Jan 19, 2024
Merged
[fix](injection) don't disturb CLOSE_LOAD message in LoadStream#30097dataroaring merged 1 commit intoapache:masterfrom
dataroaring merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38605 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 176385 ms |
ClickBench: Total hot run time: 31.33 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
CalvinKirs
approved these changes
Jan 19, 2024
liaoxin01
reviewed
Jan 19, 2024
| }); | ||
| // CLOSE_LOAD message should not be fault injected, | ||
| // otherwise the message will be ignored and causing close wait timeout | ||
| if (hdr.opcode() != PStreamHeader::CLOSE_LOAD) { |
Contributor
There was a problem hiding this comment.
DBUG_EXECUTE_IF("LoadStream._dispatch.unknown_loadid", {
if (hdr.opcode() != PStreamHeader::CLOSE_LOAD) {
PUniqueId& load_id = const_cast<PUniqueId&>(hdr.load_id());
load_id.set_hi(UNKNOWN_ID_FOR_TEST);
load_id.set_lo(UNKNOWN_ID_FOR_TEST);
}
});
Placing the if condition into the debug point may be better.
yiguolei
pushed a commit
that referenced
this pull request
Jan 19, 2024
hello-stephen
pushed a commit
to hello-stephen/doris
that referenced
this pull request
Jan 19, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Although it's OK to disturb CLOSE_LOAD message in LoadStream,
doing so will also make these cases run very slow (till close wait timeout).
This PR removes fault injection to CLOSE_LOAD message.
Missing CLOSE_LOAD will only be tested in cases for close_wait timeout.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...