[improvement](statistics)Optimize drop stats operation.#30144
Merged
morrySnow merged 1 commit intoapache:masterfrom Jan 22, 2024
Merged
[improvement](statistics)Optimize drop stats operation.#30144morrySnow merged 1 commit intoapache:masterfrom
morrySnow merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39200 ms |
TPC-DS: Total hot run time: 176178 ms |
ClickBench: Total hot run time: 30.25 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morningman
reviewed
Jan 21, 2024
fe/fe-core/src/main/java/org/apache/doris/statistics/InvalidateStatsTarget.java
Show resolved
Hide resolved
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 38562 ms |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-DS: Total hot run time: 176354 ms |
ClickBench: Total hot run time: 30.27 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
TPC-H: Total hot run time: 38662 ms |
TPC-DS: Total hot run time: 176724 ms |
ClickBench: Total hot run time: 29.74 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morrySnow
approved these changes
Jan 22, 2024
morningman
pushed a commit
that referenced
this pull request
Jan 22, 2024
Before, drop stats operation need to call columns * followers times of isMaster() function and the same times of rpc to drop remote column stats. This pr is to reduce the rpc calls and use more efficient way to check master node instead of using isMaster() backport #30144
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jan 22, 2024
Before, drop stats operation need to call columns * followers times of isMaster() function and the same times of rpc to drop remote column stats. This pr is to reduce the rpc calls and use more efficient way to check master node instead of using isMaster()
yiguolei
pushed a commit
that referenced
this pull request
Jan 23, 2024
Before, drop stats operation need to call columns * followers times of isMaster() function and the same times of rpc to drop remote column stats. This pr is to reduce the rpc calls and use more efficient way to check master node instead of using isMaster()
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
Before, drop stats operation need to call columns * followers times of isMaster() function and the same times of rpc to drop remote column stats. This pr is to reduce the rpc calls and use more efficient way to check master node instead of using isMaster() backport apache#30144
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, drop stats operation need to call columns * followers times of isMaster() function and the same times of rpc to drop remote column stats. This pr is to reduce the rpc calls and use more efficient way to check master node instead of using isMaster()
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...