Skip to content

[bugfix](paimon)add class loader #30483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 3 commits into from
Jan 30, 2024
Merged

[bugfix](paimon)add class loader #30483

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e0fc9b
add class loader
wuwenchi Jan 29, 2024
6cf47e5
fix
wuwenchi Jan 30, 2024
7875ad0
fix
wuwenchi Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions ...ava-extensions/paimon-scanner/src/main/java/org/apache/doris/paimon/PaimonJniScanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,10 @@ public class PaimonJniScanner extends JniScanner {
private long tblId;
private long lastUpdateTime;
private RecordReader.RecordIterator<InternalRow> recordIterator = null;
private final ClassLoader classLoader;

public PaimonJniScanner(int batchSize, Map<String, String> params) {
this.classLoader = this.getClass().getClassLoader();
LOG.debug("params:{}", params);
this.params = params;
String[] requiredFields = params.get("required_fields").split(",");
Expand All @@ -87,9 +89,19 @@ public PaimonJniScanner(int batchSize, Map<String, String> params) {

@Override
public void open() throws IOException {
initTable();
initReader();
resetDatetimeV2Precision();
try {
// When the user does not specify hive-site.xml, Paimon will look for the file from the classpath:
// org.apache.paimon.hive.HiveCatalog.createHiveConf:
// `Thread.currentThread().getContextClassLoader().getResource(HIVE_SITE_FILE)`
// so we need to provide a classloader, otherwise it will cause NPE.
Thread.currentThread().setContextClassLoader(classLoader);
initTable();
initReader();
resetDatetimeV2Precision();
} catch (Exception e) {
LOG.warn("Failed to open paimon_scanner: " + e.getMessage(), e);
throw e;
}
}

private void initReader() throws IOException {
Expand Down Expand Up @@ -182,7 +194,7 @@ private void initTable() {
PaimonTableCacheKey key = new PaimonTableCacheKey(ctlId, dbId, tblId, paimonOptionParams, dbName, tblName);
TableExt tableExt = PaimonTableCache.getTable(key);
if (tableExt.getCreateTime() < lastUpdateTime) {
LOG.warn("invalidate cacha table:{}, localTime:{}, remoteTime:{}", key, tableExt.getCreateTime(),
LOG.warn("invalidate cache table:{}, localTime:{}, remoteTime:{}", key, tableExt.getCreateTime(),
lastUpdateTime);
PaimonTableCache.invalidateTableCache(key);
tableExt = PaimonTableCache.getTable(key);
Expand Down