[fix](Nereids) decimalv3 cast in fe produce wrong data (#29808)#30522
Merged
morrySnow merged 1 commit intoapache:branch-2.0from Jan 30, 2024
Merged
[fix](Nereids) decimalv3 cast in fe produce wrong data (#29808)#30522morrySnow merged 1 commit intoapache:branch-2.0from
morrySnow merged 1 commit intoapache:branch-2.0from
Conversation
case: ``` MySQL root@127.0.0.1:test> select cast(12 as decimalv3(2,1)) +-----------------------------+ | cast(12 as DECIMALV3(2, 1)) | +-----------------------------+ | 12.0 | +-----------------------------+ ``` decimalv2 literal will generate wrong result too. But it is not only bugs in planner, but also have bugs in executor. So we need fix executor bug in another PR. pick from master apache#29808 commi id 88ef595
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 49812 ms |
TPC-DS: Total hot run time: 237203 ms |
ClickBench: Total hot run time: 30.25 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Apr 9, 2024
…apache#30522) case: ``` MySQL root@127.0.0.1:test> select cast(12 as decimalv3(2,1)) +-----------------------------+ | cast(12 as DECIMALV3(2, 1)) | +-----------------------------+ | 12.0 | +-----------------------------+ ``` decimalv2 literal will generate wrong result too. But it is not only bugs in planner, but also have bugs in executor. So we need fix executor bug in another PR. pick from master apache#29808 commi id 88ef595
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…apache#30522) case: ``` MySQL root@127.0.0.1:test> select cast(12 as decimalv3(2,1)) +-----------------------------+ | cast(12 as DECIMALV3(2, 1)) | +-----------------------------+ | 12.0 | +-----------------------------+ ``` decimalv2 literal will generate wrong result too. But it is not only bugs in planner, but also have bugs in executor. So we need fix executor bug in another PR. pick from master apache#29808 commi id 88ef595
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
case:
decimalv2 literal will generate wrong result too. But it is not only bugs in planner, but also have bugs in executor. So we need fix executor bug in another PR.
pick from master #29808
commi id 88ef595
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...