[fix](move-memtable) check load timeout before close wait#30526
Merged
dataroaring merged 1 commit intoapache:masterfrom Jan 30, 2024
Merged
[fix](move-memtable) check load timeout before close wait#30526dataroaring merged 1 commit intoapache:masterfrom
dataroaring merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38074 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 173944 ms |
ClickBench: Total hot run time: 30.72 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
gavinchou
approved these changes
Jan 29, 2024
gavinchou
approved these changes
Jan 29, 2024
| _timeout_watch.elapsed_time() / 1000 / 1000; | ||
| if (remain_ms <= 0) { | ||
| LOG(WARNING) << "load timed out before close waiting, load_id=" | ||
| << print_id(_load_id); |
Contributor
There was a problem hiding this comment.
better print remain_ms too
yiguolei
pushed a commit
that referenced
this pull request
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
close wait timeout = load timeout - elapsed time
If remaining time is not positive, return timeout
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...