Skip to content

[fix](compile) be cannot compile on MacOS (#26155)#30764

Merged
yiguolei merged 1 commit into
apache:branch-2.0from
cambyzju:fix-0202-compile
Feb 3, 2024
Merged

[fix](compile) be cannot compile on MacOS (#26155)#30764
yiguolei merged 1 commit into
apache:branch-2.0from
cambyzju:fix-0202-compile

Conversation

@cambyzju
Copy link
Copy Markdown
Contributor

@cambyzju cambyzju commented Feb 2, 2024

build on MacOS meet error: reference to 'detail' is ambiguous. Because there is a detail namespace under std

Proposed changes

cherry-pick #26155 to branch 2.0, otherwise we compile failed with following errors:

/Users/zhuxiaoli/Codes/doris-2.0/be/src/vec/common/memcpy_small.h:68:5: error: reference to 'detail' is ambiguous
    detail::memcpy_small_allow_read_write_overflow15_impl(reinterpret_cast<char*>(dst),
    ^
/Users/zhuxiaoli/Codes/doris-2.0/be/src/vec/common/memcpy_small.h:49:11: note: candidate found by name lookup is 'detail'
namespace detail {
          ^
/Users/zhuxiaoli/Codes/doris-2.0/be/../thirdparty/installed/include/boost/multiprecision/cpp_int/limits.hpp:15:11: note: candidate found by name lookup is 'std::detail'
namespace detail {

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

build on MacOS meet error: reference to 'detail' is ambiguous.
Because there is a detail namespace under std
@doris-robot
Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@cambyzju
Copy link
Copy Markdown
Contributor Author

cambyzju commented Feb 2, 2024

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

TPC-H: Total hot run time: 50763 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1bf8a2ce3dfab4e505dabef00c9a52f717b86b2a, data reload: false

------ Round 1 ----------------------------------
q1	17543	4386	4377	4377
q2	2042	163	146	146
q3	10261	1952	1941	1941
q4	10332	1294	1346	1294
q5	8717	4100	4044	4044
q6	234	124	124	124
q7	2032	1581	1611	1581
q8	9272	2756	2771	2756
q9	11219	12117	10799	10799
q10	8665	3539	3517	3517
q11	427	246	242	242
q12	475	293	304	293
q13	18375	4023	4022	4022
q14	360	335	343	335
q15	502	460	459	459
q16	697	599	593	593
q17	1140	981	966	966
q18	7383	7008	6921	6921
q19	1724	1566	1530	1530
q20	527	300	311	300
q21	4518	4177	4113	4113
q22	516	410	411	410
Total cold run time: 116961 ms
Total hot run time: 50763 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4337	4348	4322	4322
q2	330	223	221	221
q3	4174	4169	4147	4147
q4	2767	2751	2748	2748
q5	7370	7210	7226	7210
q6	237	118	117	117
q7	3283	2832	2782	2782
q8	4313	4495	4484	4484
q9	17605	17563	17411	17411
q10	4264	4303	4255	4255
q11	753	687	703	687
q12	1016	832	857	832
q13	6397	3756	3785	3756
q14	452	424	416	416
q15	498	450	453	450
q16	768	707	695	695
q17	3794	3793	3804	3793
q18	8931	8879	8908	8879
q19	1726	1721	1664	1664
q20	2376	2157	2104	2104
q21	8479	8614	8460	8460
q22	1042	978	927	927
Total cold run time: 84912 ms
Total hot run time: 80360 ms

@doris-robot
Copy link
Copy Markdown

TeamCity be ut coverage result:
Function Coverage: 37.84% (8034/21232)
Line Coverage: 29.54% (65469/221633)
Region Coverage: 28.96% (33623/116121)
Branch Coverage: 24.82% (17255/69520)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1bf8a2ce3dfab4e505dabef00c9a52f717b86b2a_1bf8a2ce3dfab4e505dabef00c9a52f717b86b2a/report/index.html

@doris-robot
Copy link
Copy Markdown

TPC-DS: Total hot run time: 241990 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1bf8a2ce3dfab4e505dabef00c9a52f717b86b2a, data reload: false

query1	917	386	379	379
query2	6511	2300	2220	2220
query3	6912	204	202	202
query4	19950	17735	17960	17735
query5	19720	6220	6219	6219
query6	276	214	215	214
query7	4152	295	295	295
query8	265	217	222	217
query9	3063	2654	2583	2583
query10	405	296	296	296
query11	11226	10594	10540	10540
query12	125	73	74	73
query13	5656	639	618	618
query14	17404	13293	13290	13290
query15	363	240	229	229
query16	6455	258	263	258
query17	3207	883	856	856
query18	2259	397	403	397
query19	201	145	160	145
query20	69	76	70	70
query21	191	90	91	90
query22	5222	4983	4915	4915
query23	32737	32045	31953	31953
query24	6966	6507	6440	6440
query25	514	438	408	408
query26	531	155	155	155
query27	1901	291	296	291
query28	6126	2224	2195	2195
query29	2858	2846	2750	2750
query30	237	161	160	160
query31	893	735	708	708
query32	71	59	57	57
query33	394	254	244	244
query34	850	457	488	457
query35	1148	933	945	933
query36	1550	1362	1578	1362
query37	90	57	59	57
query38	3054	2956	2908	2908
query39	1360	1323	1314	1314
query40	195	91	101	91
query41	34	31	32	31
query42	96	74	83	74
query43	670	579	552	552
query44	1162	709	705	705
query45	240	232	224	224
query46	1228	967	958	958
query47	2185	1847	1727	1727
query48	981	677	679	677
query49	626	370	352	352
query50	864	615	601	601
query51	5506	5504	5483	5483
query52	88	92	86	86
query53	445	316	318	316
query54	2434	2278	2248	2248
query55	81	80	85	80
query56	221	198	200	198
query57	1075	1140	1111	1111
query58	208	186	186	186
query59	3420	3384	3172	3172
query60	198	192	186	186
query61	86	79	81	79
query62	808	496	456	456
query63	478	332	337	332
query64	1994	1321	1349	1321
query65	3705	3620	3605	3605
query66	828	369	352	352
query67	16443	16130	15221	15221
query68	8455	662	657	657
query69	554	349	329	329
query70	2182	1856	1799	1799
query71	371	299	304	299
query72	4422	3319	3289	3289
query73	717	322	331	322
query74	6273	5881	5811	5811
query75	4216	3422	3452	3422
query76	4969	1099	1114	1099
query77	781	250	261	250
query78	32692	54686	52264	52264
query79	15522	654	637	637
query80	4700	375	376	375
query81	571	232	229	229
query82	1601	104	98	98
query83	334	133	131	131
query84	255	70	67	67
query85	1851	289	279	279
query86	445	377	431	377
query87	3214	2994	3000	2994
query88	7356	2341	2338	2338
query89	465	298	282	282
query90	2516	207	196	196
query91	155	114	117	114
query92	63	50	53	50
query93	6835	593	614	593
query94	1657	205	196	196
query95	1094	1069	1080	1069
query96	638	329	335	329
query97	6617	6381	6447	6381
query98	190	174	173	173
query99	3664	884	913	884
Total cold run time: 347503 ms
Total hot run time: 241990 ms

@doris-robot
Copy link
Copy Markdown

ClickBench: Total hot run time: 32.56 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1bf8a2ce3dfab4e505dabef00c9a52f717b86b2a, data reload: false

query1	0.02	0.02	0.03
query2	0.06	0.02	0.02
query3	0.24	0.05	0.05
query4	1.82	0.07	0.06
query5	0.54	0.52	0.52
query6	1.30	0.61	0.61
query7	0.01	0.01	0.01
query8	0.03	0.02	0.03
query9	0.52	0.47	0.48
query10	0.54	0.52	0.54
query11	0.12	0.08	0.09
query12	0.12	0.10	0.09
query13	0.61	0.62	0.60
query14	0.78	0.79	0.79
query15	0.77	0.76	0.75
query16	0.40	0.37	0.36
query17	1.02	1.00	1.00
query18	0.23	0.26	0.26
query19	1.92	1.83	1.84
query20	0.01	0.01	0.01
query21	15.48	0.54	0.54
query22	2.02	2.42	1.55
query23	17.67	0.81	0.94
query24	4.67	2.94	2.91
query25	1.52	0.13	0.11
query26	0.40	0.13	0.13
query27	0.11	0.11	0.10
query28	5.42	0.73	0.74
query29	12.65	2.28	2.37
query30	0.54	0.52	0.52
query31	2.83	0.36	0.39
query32	3.43	0.50	0.49
query33	3.13	3.06	3.10
query34	15.27	4.81	4.80
query35	4.85	4.84	4.85
query36	1.06	1.02	1.01
query37	0.06	0.05	0.04
query38	0.04	0.02	0.02
query39	0.01	0.02	0.02
query40	0.16	0.14	0.15
query41	0.06	0.02	0.01
query42	0.02	0.01	0.02
query43	0.02	0.02	0.01
Total cold run time: 102.48 s
Total hot run time: 32.56 s

@doris-robot
Copy link
Copy Markdown

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 1bf8a2ce3dfab4e505dabef00c9a52f717b86b2a with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.6 seconds inserted 10000000 Rows, about 462K ops/s

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Feb 2, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2024

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 9af9c3c into apache:branch-2.0 Feb 3, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
build on MacOS meet error: reference to 'detail' is ambiguous.
Because there is a detail namespace under std

Co-authored-by: morrySnow <101034200+morrySnow@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants