[fix](Nereids) date >= simplify to > by mistake by morrySnow · Pull Request #30765 · apache/doris

morrySnow · 2024-02-02T09:12:12Z

intro by PR #27960

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

doris-robot · 2024-02-02T09:12:17Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

morrySnow · 2024-02-02T09:12:33Z

run buildall

doris-robot · 2024-02-02T09:42:29Z

TPC-H: Total hot run time: 36780 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 376630d18f9b89289de1634aa36f745d460bb7f3, data reload: false

------ Round 1 ----------------------------------
q1	17631	4450	4345	4345
q2	2031	140	138	138
q3	10595	905	935	905
q4	4646	744	706	706
q5	7683	2767	2815	2767
q6	181	120	120	120
q7	1128	720	710	710
q8	9248	1988	2019	1988
q9	7243	6365	6349	6349
q10	8091	2453	2409	2409
q11	413	205	203	203
q12	779	278	271	271
q13	18008	3290	3291	3290
q14	281	254	250	250
q15	531	503	493	493
q16	482	400	396	396
q17	922	534	511	511
q18	6703	5948	5920	5920
q19	1562	1352	1376	1352
q20	624	317	331	317
q21	6788	3035	3030	3030
q22	812	310	311	310
Total cold run time: 106382 ms
Total hot run time: 36780 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4346	4476	4523	4476
q2	337	245	242	242
q3	2960	2799	2786	2786
q4	1835	1611	1655	1611
q5	5137	5196	5175	5175
q6	189	116	116	116
q7	2158	1739	1738	1738
q8	3078	3261	3234	3234
q9	8331	8283	8319	8283
q10	5786	3584	3596	3584
q11	533	466	460	460
q12	733	578	558	558
q13	11654	3086	3096	3086
q14	271	259	269	259
q15	531	492	491	491
q16	504	485	482	482
q17	1826	1681	1688	1681
q18	7964	7786	7632	7632
q19	10199	1561	1564	1561
q20	2156	1929	1926	1926
q21	4966	4578	4497	4497
q22	547	482	454	454
Total cold run time: 76041 ms
Total hot run time: 54332 ms

morrySnow · 2024-02-02T09:52:45Z

run feut

doris-robot · 2024-02-02T09:53:52Z

TPC-DS: Total hot run time: 174162 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 376630d18f9b89289de1634aa36f745d460bb7f3, data reload: false

query1	943	345	330	330
query2	6530	1949	1863	1863
query3	6721	202	209	202
query4	32077	22057	22005	22005
query5	4300	369	351	351
query6	258	162	165	162
query7	4593	280	280	280
query8	243	172	192	172
query9	9164	2305	2313	2305
query10	420	232	216	216
query11	18319	15272	15326	15272
query12	128	78	74	74
query13	1635	429	426	426
query14	9357	6716	6769	6716
query15	210	178	178	178
query16	8106	257	248	248
query17	1712	548	521	521
query18	2100	261	274	261
query19	190	142	139	139
query20	83	79	79	79
query21	209	128	120	120
query22	4899	4693	4681	4681
query23	30785	29972	30087	29972
query24	10174	2721	2780	2721
query25	564	346	338	338
query26	715	141	145	141
query27	2235	296	303	296
query28	5721	1881	1861	1861
query29	887	615	619	615
query30	282	134	140	134
query31	954	703	719	703
query32	92	65	47	47
query33	626	220	215	215
query34	820	462	455	455
query35	823	760	752	752
query36	1028	955	907	907
query37	87	58	56	56
query38	3252	3082	3123	3082
query39	1327	1255	1251	1251
query40	180	94	92	92
query41	36	34	35	34
query42	99	90	92	90
query43	502	472	481	472
query44	1081	683	707	683
query45	190	180	172	172
query46	1044	631	631	631
query47	1494	1496	1428	1428
query48	459	362	351	351
query49	1068	298	288	288
query50	793	389	385	385
query51	5264	5106	5173	5106
query52	103	88	85	85
query53	335	284	273	273
query54	271	211	216	211
query55	80	75	76	75
query56	227	205	198	198
query57	944	891	895	891
query58	194	177	173	173
query59	2456	2402	2395	2395
query60	244	214	216	214
query61	94	84	82	82
query62	639	385	369	369
query63	299	276	271	271
query64	4725	3263	3590	3263
query65	3270	3251	3219	3219
query66	812	313	302	302
query67	14458	14173	14176	14173
query68	5490	544	524	524
query69	496	343	330	330
query70	1298	1256	1227	1227
query71	346	248	244	244
query72	6279	2833	2694	2694
query73	704	325	326	325
query74	6604	6247	6260	6247
query75	3093	2329	2318	2318
query76	3500	994	965	965
query77	360	233	222	222
query78	9280	8722	8655	8655
query79	2358	494	489	489
query80	1854	353	339	339
query81	538	199	196	196
query82	729	79	85	79
query83	239	125	124	124
query84	272	77	79	77
query85	2188	329	338	329
query86	496	301	288	288
query87	3334	3189	3214	3189
query88	3877	2319	2296	2296
query89	456	368	368	368
query90	1980	163	161	161
query91	167	120	118	118
query92	57	43	42	42
query93	2563	489	485	485
query94	1295	176	172	172
query95	8133	347	7875	347
query96	598	279	273	273
query97	4208	4100	4102	4100
query98	223	205	186	186
query99	1052	680	724	680
Total cold run time: 287997 ms
Total hot run time: 174162 ms

pick from master apache#30765

doris-robot · 2024-02-02T09:59:18Z

ClickBench: Total hot run time: 30.89 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 376630d18f9b89289de1634aa36f745d460bb7f3, data reload: false

query1	0.03	0.03	0.02
query2	0.06	0.03	0.02
query3	0.23	0.06	0.06
query4	1.68	0.09	0.10
query5	0.53	0.51	0.52
query6	1.18	0.68	0.66
query7	0.01	0.01	0.02
query8	0.04	0.03	0.02
query9	0.56	0.50	0.50
query10	0.54	0.59	0.53
query11	0.11	0.08	0.08
query12	0.11	0.10	0.09
query13	0.61	0.61	0.61
query14	0.79	0.81	0.80
query15	0.79	0.77	0.78
query16	0.39	0.36	0.38
query17	1.02	1.03	1.01
query18	0.21	0.28	0.21
query19	1.82	1.74	1.74
query20	0.01	0.01	0.01
query21	15.40	0.57	0.56
query22	2.91	2.67	2.08
query23	17.14	1.05	0.76
query24	2.41	0.81	1.63
query25	0.34	0.14	0.16
query26	0.68	0.13	0.14
query27	0.04	0.07	0.04
query28	11.24	0.85	0.86
query29	12.53	3.06	3.16
query30	0.60	0.56	0.55
query31	2.80	0.34	0.34
query32	3.40	0.47	0.48
query33	3.28	3.25	3.17
query34	15.68	4.25	4.35
query35	4.42	4.34	4.28
query36	1.09	1.04	1.05
query37	0.06	0.04	0.05
query38	0.04	0.03	0.03
query39	0.02	0.02	0.01
query40	0.17	0.13	0.13
query41	0.07	0.02	0.02
query42	0.03	0.02	0.01
query43	0.02	0.02	0.02
Total cold run time: 105.09 s
Total hot run time: 30.89 s

doris-robot · 2024-02-02T10:02:22Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 376630d18f9b89289de1634aa36f745d460bb7f3 with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       13.4 seconds inserted 10000000 Rows, about 746K ops/s

morrySnow · 2024-02-02T10:44:30Z

run feut

github-actions · 2024-02-02T11:07:57Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-02-02T11:07:59Z

PR approved by anyone and no changes requested.

morrySnow · 2024-02-02T12:35:04Z

run buildall

pick from master apache#30765

github-actions · 2024-02-02T12:37:55Z

PR approved by at least one committer and no changes requested.

doris-robot · 2024-02-02T13:06:13Z

TPC-H: Total hot run time: 37174 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ccccc20910e0ae60013d929772145bde748054c5, data reload: false

------ Round 1 ----------------------------------
q1	17875	4900	4456	4456
q2	2042	141	136	136
q3	10678	923	909	909
q4	4680	776	672	672
q5	8863	2762	2680	2680
q6	187	120	120	120
q7	1151	735	716	716
q8	9303	1994	2014	1994
q9	7267	6385	6390	6385
q10	8081	2407	2447	2407
q11	414	222	203	203
q12	753	288	282	282
q13	19285	3413	3590	3413
q14	306	258	257	257
q15	534	500	483	483
q16	542	429	445	429
q17	956	519	509	509
q18	9324	6436	5965	5965
q19	1567	1472	1377	1377
q20	592	343	324	324
q21	7129	3181	3207	3181
q22	1658	306	276	276
Total cold run time: 113187 ms
Total hot run time: 37174 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4598	4387	4529	4387
q2	328	215	232	215
q3	2976	2826	2782	2782
q4	1791	1720	1713	1713
q5	5127	5182	5144	5144
q6	193	114	114	114
q7	2167	1771	1733	1733
q8	3119	3217	3244	3217
q9	8374	8322	8296	8296
q10	5778	3548	3587	3548
q11	547	467	472	467
q12	717	568	579	568
q13	15976	3082	3076	3076
q14	283	252	255	252
q15	533	488	491	488
q16	495	444	450	444
q17	1842	1675	1719	1675
q18	7874	7620	7482	7482
q19	9210	1548	1544	1544
q20	2141	1912	1905	1905
q21	4767	4670	4581	4581
q22	573	462	445	445
Total cold run time: 79409 ms
Total hot run time: 54076 ms

doris-robot · 2024-02-02T13:17:21Z

TPC-DS: Total hot run time: 173335 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ccccc20910e0ae60013d929772145bde748054c5, data reload: false

query1	924	339	330	330
query2	6564	2053	2038	2038
query3	6689	207	203	203
query4	31520	22066	21811	21811
query5	4305	363	355	355
query6	262	169	160	160
query7	4604	287	282	282
query8	237	172	172	172
query9	8964	2297	2277	2277
query10	419	206	223	206
query11	17886	15409	15325	15325
query12	134	73	72	72
query13	1617	413	406	406
query14	9323	6856	6797	6797
query15	228	170	181	170
query16	8086	254	240	240
query17	1869	534	489	489
query18	2123	265	261	261
query19	330	142	140	140
query20	82	79	76	76
query21	202	128	120	120
query22	4790	4629	4688	4629
query23	30739	30005	29866	29866
query24	10159	2765	2735	2735
query25	530	338	340	338
query26	713	144	146	144
query27	2191	305	297	297
query28	5710	1837	1832	1832
query29	876	597	624	597
query30	283	131	139	131
query31	931	683	701	683
query32	91	51	46	46
query33	630	211	229	211
query34	840	449	453	449
query35	875	769	747	747
query36	1015	929	940	929
query37	99	57	62	57
query38	3289	3140	3094	3094
query39	1323	1251	1247	1247
query40	178	95	91	91
query41	39	34	34	34
query42	94	87	90	87
query43	526	473	481	473
query44	1045	682	701	682
query45	191	180	174	174
query46	1046	639	655	639
query47	1529	1460	1476	1460
query48	437	358	361	358
query49	1068	284	278	278
query50	755	394	376	376
query51	5265	5117	5146	5117
query52	91	91	87	87
query53	327	266	274	266
query54	283	212	220	212
query55	79	78	81	78
query56	215	193	196	193
query57	967	894	888	888
query58	200	175	176	175
query59	2362	2365	2354	2354
query60	240	218	204	204
query61	82	85	82	82
query62	649	361	341	341
query63	310	270	271	270
query64	4850	3778	3459	3459
query65	3249	3220	3234	3220
query66	810	320	306	306
query67	14549	14227	14092	14092
query68	4332	521	537	521
query69	488	329	319	319
query70	1240	1285	1182	1182
query71	311	242	248	242
query72	6055	2841	2660	2660
query73	694	329	320	320
query74	6621	6196	6103	6103
query75	3049	2331	2275	2275
query76	3236	903	872	872
query77	368	228	222	222
query78	9103	8651	8447	8447
query79	3188	480	491	480
query80	2078	351	344	344
query81	540	197	203	197
query82	864	84	78	78
query83	256	119	127	119
query84	287	79	79	79
query85	2197	334	322	322
query86	494	308	288	288
query87	3380	3212	3181	3181
query88	4158	2324	2317	2317
query89	446	367	364	364
query90	1985	162	162	162
query91	158	126	119	119
query92	55	43	42	42
query93	4816	506	460	460
query94	1300	181	169	169
query95	472	374	345	345
query96	591	264	263	263
query97	4228	4064	4085	4064
query98	213	195	193	193
query99	1213	682	628	628
Total cold run time: 281304 ms
Total hot run time: 173335 ms

doris-robot · 2024-02-02T13:22:48Z

ClickBench: Total hot run time: 31.41 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ccccc20910e0ae60013d929772145bde748054c5, data reload: false

query1	0.04	0.03	0.02
query2	0.06	0.02	0.02
query3	0.23	0.06	0.06
query4	1.65	0.09	0.10
query5	0.53	0.51	0.51
query6	1.22	0.63	0.65
query7	0.02	0.02	0.01
query8	0.05	0.03	0.03
query9	0.57	0.50	0.51
query10	0.55	0.55	0.55
query11	0.12	0.08	0.09
query12	0.11	0.08	0.08
query13	0.60	0.59	0.60
query14	0.79	0.80	0.79
query15	0.80	0.79	0.77
query16	0.38	0.39	0.38
query17	1.00	1.05	0.98
query18	0.23	0.27	0.23
query19	1.90	1.78	1.77
query20	0.01	0.01	0.01
query21	15.41	0.58	0.56
query22	2.54	2.44	2.02
query23	17.05	0.90	0.74
query24	2.66	1.16	1.17
query25	0.25	0.26	0.15
query26	0.54	0.14	0.15
query27	0.06	0.04	0.06
query28	11.19	0.85	0.85
query29	12.57	3.18	3.27
query30	0.65	0.58	0.61
query31	2.79	0.35	0.36
query32	3.33	0.48	0.48
query33	3.21	3.22	3.18
query34	15.82	4.29	4.30
query35	4.30	4.27	4.28
query36	1.09	1.06	1.07
query37	0.07	0.05	0.05
query38	0.04	0.03	0.02
query39	0.02	0.02	0.02
query40	0.15	0.12	0.12
query41	0.08	0.02	0.01
query42	0.03	0.02	0.02
query43	0.02	0.02	0.02
Total cold run time: 104.73 s
Total hot run time: 31.41 s

doris-robot · 2024-02-02T13:25:55Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit ccccc20910e0ae60013d929772145bde748054c5 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       13.5 seconds inserted 10000000 Rows, about 740K ops/s

pick from master #30765

pick from master apache#30765

morrySnow requested a review from englefly February 2, 2024 09:12

morrySnow added usercase Important user case type label p0_w dev/2.0.5 labels Feb 2, 2024

morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Feb 2, 2024

[fix](Nereids) date >= simplify to > by mistake

eb2cf11

pick from master apache#30765

morrySnow mentioned this pull request Feb 2, 2024

[fix](Nereids) date >= simplify to > by mistake #30768

Merged

englefly previously approved these changes Feb 2, 2024

View reviewed changes

github-actions Bot added the approved Indicates a PR has been approved by one committer. label Feb 2, 2024

github-actions Bot added the reviewed label Feb 2, 2024

[fix](Nereids) date >= simplify to > by mistake

ccccc20

morrySnow dismissed englefly’s stale review via ccccc20 February 2, 2024 12:34

morrySnow force-pushed the fix_date_function_rewrite branch from 376630d to ccccc20 Compare February 2, 2024 12:34

github-actions Bot removed the approved Indicates a PR has been approved by one committer. label Feb 2, 2024

morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Feb 2, 2024

[fix](Nereids) date >= simplify to > by mistake

88094e1

pick from master apache#30765

starocean999 approved these changes Feb 2, 2024

View reviewed changes

github-actions Bot added the approved Indicates a PR has been approved by one committer. label Feb 2, 2024

morrySnow added a commit that referenced this pull request Feb 2, 2024

[fix](Nereids) date >= simplify to > by mistake (#30768)

a829c63

pick from master #30765

wm1581066 added dev/2.0.5-merged and removed dev/2.0.5 labels Feb 3, 2024

yiguolei approved these changes Feb 3, 2024

View reviewed changes

yiguolei merged commit 66c2b29 into apache:master Feb 3, 2024

yiguolei pushed a commit that referenced this pull request Feb 3, 2024

[fix](Nereids) date >= simplify to > by mistake (#30765)

4f0414d

morrySnow deleted the fix_date_function_rewrite branch February 4, 2024 01:45

eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Apr 9, 2024

[fix](Nereids) date >= simplify to > by mistake (apache#30768)

e8ba7c9

pick from master apache#30765

mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024

[fix](Nereids) date >= simplify to > by mistake (apache#30768)

78424f7

pick from master apache#30765

HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Apr 24, 2026

[fix](Nereids) date >= simplify to > by mistake (apache#30765)

c719cfc

Conversation

morrySnow commented Feb 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Further comments

Uh oh!

doris-robot commented Feb 2, 2024

Uh oh!

morrySnow commented Feb 2, 2024

Uh oh!

doris-robot commented Feb 2, 2024

Uh oh!

morrySnow commented Feb 2, 2024

Uh oh!

doris-robot commented Feb 2, 2024

Uh oh!

doris-robot commented Feb 2, 2024

Uh oh!

doris-robot commented Feb 2, 2024

Uh oh!

morrySnow commented Feb 2, 2024

Uh oh!

github-actions Bot commented Feb 2, 2024

Uh oh!

github-actions Bot commented Feb 2, 2024

Uh oh!

morrySnow commented Feb 2, 2024

Uh oh!

github-actions Bot commented Feb 2, 2024

Uh oh!

doris-robot commented Feb 2, 2024

Uh oh!

doris-robot commented Feb 2, 2024

Uh oh!

doris-robot commented Feb 2, 2024

Uh oh!

doris-robot commented Feb 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

morrySnow commented Feb 2, 2024 •

edited

Loading