[feature](load) support compressed JSON format data for broker load#30801
Closed
elvestar wants to merge 1 commit intoapache:masterfrom
Closed
[feature](load) support compressed JSON format data for broker load#30801elvestar wants to merge 1 commit intoapache:masterfrom
elvestar wants to merge 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return st; | ||
| } | ||
|
|
||
| Status Decompressor::create_decompressor(TFileCompressType::type type, Decompressor** decompressor) { |
Contributor
There was a problem hiding this comment.
warning: method 'create_decompressor' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status Decompressor::create_decompressor(TFileCompressType::type type, Decompressor** decompressor) { | |
| static Status Decompressor::create_decompressor(TFileCompressType::type type, Decompressor** decompressor) { |
Contributor
Author
There was a problem hiding this comment.
I have already declared the method as static in the header file, and this warning is likely a false positive.
| return Status::OK(); | ||
| } | ||
|
|
||
| Status Decompressor::create_decompressor(TFileFormatType::type type, Decompressor** decompressor) { |
Contributor
There was a problem hiding this comment.
warning: method 'create_decompressor' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status Decompressor::create_decompressor(TFileFormatType::type type, Decompressor** decompressor) { | |
| static Status Decompressor::create_decompressor(TFileFormatType::type type, Decompressor** decompressor) { |
Contributor
Author
There was a problem hiding this comment.
I have already declared the method as static in the header file, and this warning is likely a false positive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
We have a large amount of data stored in HDFS in GZIP-compressed JSON format, and currently Doris does not support loading compressed JSON format data.
Upgrade points:
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...