[refactor](queryctx) move tg related code to task group#30829
Merged
yiguolei merged 13 commits intoapache:masterfrom Feb 6, 2024
Merged
[refactor](queryctx) move tg related code to task group#30829yiguolei merged 13 commits intoapache:masterfrom
yiguolei merged 13 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. |
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37197 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 181999 ms |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| void add_query(TUniqueId query_id) { _query_id_set.insert(query_id); } | ||
| void add_query(TUniqueId query_id) { |
Contributor
There was a problem hiding this comment.
warning: method 'add_query' can be made static [readability-convert-member-functions-to-static]
Suggested change
| void add_query(TUniqueId query_id) { | |
| static void add_query(TUniqueId query_id) { |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
zclllyybb
approved these changes
Feb 5, 2024
Contributor
|
PR approved by anyone and no changes requested. |
wangbo
reviewed
Feb 5, 2024
| return _query_id_set.size(); | ||
| } | ||
|
|
||
| bool is_shutdown() { return _is_shutdown; } |
Contributor
There was a problem hiding this comment.
You'd better drop task group's shutdown as well
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37352 ms |
TPC-DS: Total hot run time: 174343 ms |
ClickBench: Total hot run time: 29.96 s |
|
TeamCity be ut coverage result: |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 37406 ms |
TPC-DS: Total hot run time: 173616 ms |
ClickBench: Total hot run time: 30.27 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
yiguolei
added a commit
that referenced
this pull request
Feb 6, 2024
init query ctx memtracker in queryctx constructor set all task group related property during set taskgroup
yiguolei
added a commit
that referenced
this pull request
Feb 16, 2024
init query ctx memtracker in queryctx constructor set all task group related property during set taskgroup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...